www.webdeveloper.com
Results 1 to 2 of 2

Thread: Javascript Validation Issues

  1. #1
    Join Date
    Jun 2012
    Posts
    2

    Javascript Validation Issues

    Hey guys,

    I was asked to go through our product pages and fix validation issues I could find using the w3c validator for an e-commerce company I work at. I have validated almost everything but have been having issues with some javascript. I am more of a back-end developer so javascript is not my forte. Anyways here is the original code that was causing issues:
    ----------------------------------------------------------------------------
    <script type="text/javascript">

    var norm = {price};
    var special = "{special_price}";
    var list = {list_price};
    var end = "{special_to_date}";
    var endComp = parse_date(end).getTime();
    var start = "{special_from_date}";
    var startComp = parse_date(start).getTime();
    var now = new Date().getTime();


    var specialTrue = '<div class="special-price"><span class="price-label">Our Price: </span><span class="price" id="product-price">{special_price_formatted}</span></div>';

    var specialFalse = '<div class="our-price"><span class="price-label">Our Price: </span><span class="price">{price_formatted}</span></div>';

    var specialFalseAlt = '<div class="our-price alt"><span class="price-label">Our Price: </span><span class="price">{price_formatted}</span></div>';

    if (isNaN(special) === false && endComp > now && startComp < now) {
    document.write(specialTrue)
    }else {

    if (list <= norm){
    document.write(specialFalseAlt)

    }else {
    document.write(specialFalse)
    }
    };
    </script>

    ------------------------------------------------------------------------------

    So the validator doesn't like all these divs in the javascript variables. So I changed it to this:

    ------------------------------------------------------------------------------

    <script type="text/javascript">
    var norm = {price};
    var special = "{special_price}";
    var list = {list_price};
    var end = "{special_to_date}";
    var endComp = parse_date(end).getTime();
    var start = "{special_from_date}";
    var startComp = parse_date(start).getTime();
    var now = new Date().getTime();
    var specialFormat = "{special_price_formatted}";
    var priceFormat = "{price_formatted}";
    var label = "Our Price";

    if (isNaN(special) === false && endComp > now && startComp < now) {
    document.getElementById('product-price').innerHTML += specialFormat;
    document.getElementById('product-price-label').innerHTML += label;
    }else {
    if (list <= norm){
    document.getElementById('our-price-alt').innerHTML += priceFormat;
    document.getElementById('our-price-alt-label').innerHTML += label;
    }else {
    document.getElementById('our-price').innerHTML += priceFormat;
    document.getElementById('our-price-label').innerHTML += label;
    }
    };
    </script>

    <div class="special-price"><span class="price-label" id='product-price-label'>&nbsp;</span><span class="price" id="product-price">&nbsp;</span></div>

    <div class="our-price"><span class="price-label" id='our-price-label'>&nbsp;</span><span class="price" id='our-price'>&nbsp;</span></div>

    <div class="our-price alt"><span class="price-label" id='our-price-alt-label'>&nbsp;</span><span class="price" id='our-price-alt'>&nbsp;</span></div>

    ----------------------------------------------------------------------------

    I have tried many different variations of this with no luck. Any advice on this is appreciated.

  2. #2
    Join Date
    Jun 2012
    Posts
    2
    For anyone who is curious the divs needed to be put before the javascript code.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.12627 seconds
  • Memory Usage 2,841KB
  • Queries Executed 15 (?)
More Information
Template Usage (32):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (2)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates