www.webdeveloper.com
Results 1 to 9 of 9

Thread: Shorten this code?

Hybrid View

  1. #1
    Join Date
    May 2012
    Posts
    16

    Shorten this code?

    Is there a way to short and make this function faster, smaller and better?

    function rand() {
    var r = Math.floor(Math.random()*array.length);
    document.getElementById('obj').innerHTML = array[r];
    }

  2. #2
    Join Date
    Dec 2005
    Location
    TX
    Posts
    7,942

    Exclamation

    Quote Originally Posted by WayneISWayne View Post
    Is there a way to short and make this function faster, smaller and better?

    function rand() {
    var r = Math.floor(Math.random()*array.length);
    document.getElementById('obj').innerHTML = array[r];
    }
    Don't know why you would want to do that but...
    Code:
    function rand() {
      document.getElementById('obj').innerHTML = array[Math.floor(Math.random()*array.length)];
    }
    Unless you are repeating it like a million times, I don't think the space or time difference will be significant!

  3. #3
    Join Date
    May 2012
    Posts
    16
    Thank you so much! I'm trying to make a really small JavaScript for less load time etc... and better on benchmarks too.

  4. #4
    Join Date
    Oct 2010
    Location
    Versailles, France
    Posts
    1,290
    A shorter method ?
    Code:
    function rand() {
      document.getElementById('obj').innerHTML = array[~~(Math.random()*array.length)];
    }

  5. #5
    Join Date
    May 2012
    Posts
    16
    Quote Originally Posted by 007Julien View Post
    A shorter method ?
    Code:
    function rand() {
      document.getElementById('obj').innerHTML = array[~~(Math.random()*array.length)];
    }
    Dose the tilde work on all browsers?

  6. #6
    Join Date
    Aug 2007
    Posts
    3,767
    Well, if you are repeating that a lot, it's not good to be calling document.getElementById so much. Storing a reference would probably be better. Short code doesn't necessarily mean it's faster.

  7. #7
    Join Date
    May 2012
    Posts
    16
    Quote Originally Posted by Declan1991 View Post
    Well, if you are repeating that a lot, it's not good to be calling document.getElementById so much. Storing a reference would probably be better. Short code doesn't necessarily mean it's faster.
    I know. If I do that, there would be a lot of function calls. I wish there was a better way of doing the getElementById.

  8. #8
    Join Date
    Mar 2007
    Location
    U.K.
    Posts
    1,127
    Quote Originally Posted by WayneISWayne View Post
    I know. If I do that, there would be a lot of function calls. I wish there was a better way of doing the getElementById.
    Code:
    var rand = ( function () 
    {   
      var elem = document.getElementById( 'obj' );
    
      return function()
      {
        elem.innerHTML = array[ Math.floor( Math.random() * array.length ) ]; 
      }  
    
    } )();
    Where used, return should be executed unconditionally and always as the last statement in the function.

    That's my signature, it's not part of the damn post!

  9. #9
    Join Date
    Oct 2010
    Location
    Versailles, France
    Posts
    1,290
    As an example, you can see this page which play chess (no castling and en passant capture) with a 1023 bytes javascript !

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.19690 seconds
  • Memory Usage 3,159KB
  • Queries Executed 13 (?)
More Information
Template Usage (31):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (4)bbcode_code
  • (4)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (9)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (9)postbit
  • (9)postbit_onlinestatus
  • (9)postbit_wrapper
  • (1)showthread_list
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (27):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./includes/functions_threadedmode.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids_threaded
  • showthread_threaded_construct_link
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates