www.webdeveloper.com
Results 1 to 15 of 15

Thread: Review of CSS Code

  1. #1
    Join Date
    Aug 2004
    Location
    Toronto, Ontario (Canada)
    Posts
    100

    Review of CSS Code

    Hi there,

    Can I post a site here so someone can review the CSS code & tell me if it's clean, semantic, valid, etc.?


    Michelle

  2. #2
    Join Date
    Mar 2012
    Posts
    1,494
    Why not validate it first? Google "CSS Validation", oh and validating the HTML would be a good idea too. "HTML Validation" should give you the links you need. I use the WDG HTML validator rather than the W3C one.

  3. #3
    Join Date
    Aug 2004
    Location
    Toronto, Ontario (Canada)
    Posts
    100
    I already know the URLs for validation & that's what I used to do before, but then several people on another forum said that code doesn't have to be 100% validated in order to be great code.

    I thought someone on here could review the code & tell me if it's good. Of course that person would have be an excellent coder themselves LOL

    Thanks


    Michelle

  4. #4
    Join Date
    Mar 2012
    Posts
    1,494
    Admittedly, there is a lot more to good coding than just its validity. Also, there are reasons why you may use "invalid" code, e.g. to use the css3 "radius" attribute in an html4/css2 page. The major browsers generally support it (not IE8 or earlier) so why not use it? But that is not a good reason for not validating your code.

    All invalid code puts you at the mercy of the error handling of the different browsers. They will, in some cases, handle the "error" consistently and beneficially (as above), but generally not. So validating the code is a necessary part of ensuring consistent behaviour on a range of browsers.
    Last edited by jedaisoul; 06-21-2012 at 11:35 AM.

  5. #5
    Join Date
    Aug 2004
    Location
    Toronto, Ontario (Canada)
    Posts
    100
    Exactly, so can I post the URL here for you to look at?

    Thank you


    Michelle

  6. #6
    Join Date
    Jun 2006
    Location
    Boston, MA
    Posts
    383
    one of my favorite tools: http://www.csscompressor.com/

    it will compress code and let you know which items are 'invalid', that doesn't mean they don't work, obv they will, but not in all browser, namely IE (bleh)
    "Problems cannot be solved by the same level of thinking that created them.

  7. #7
    Join Date
    Aug 2004
    Location
    Toronto, Ontario (Canada)
    Posts
    100
    My thread seems to have been highjacked. I am NOT asking for tools, I'm asking for someone who is well versed in CSS & html to check this person's code.


    Michelle

  8. #8
    Join Date
    Jun 2006
    Location
    Boston, MA
    Posts
    383
    Quote Originally Posted by ep2002 View Post
    My thread seems to have been highjacked. I am NOT asking for tools, I'm asking for someone who is well versed in CSS & html to check this person's code.


    Michelle
    the tool will fix any format redundancies and syntax issues. i'd do that before sending it for review.
    "Problems cannot be solved by the same level of thinking that created them.

  9. #9
    Join Date
    Aug 2004
    Location
    Toronto, Ontario (Canada)
    Posts
    100
    Why would i want to fix someone else's site for them? I'm trying to see if she knows how to code properly.

  10. #10
    Join Date
    Jun 2006
    Location
    Boston, MA
    Posts
    383
    ah, like a type of job interview?
    "Problems cannot be solved by the same level of thinking that created them.

  11. #11
    Join Date
    Mar 2012
    Posts
    1,494
    Quote Originally Posted by ep2002 View Post
    Exactly, so can I post the URL here for you to look at?
    I do not consider myself to be a web guru, for the simple reason that I am sure there is a lot more that I do not know about coding web pages than I do know.

    My only purpose was to suggest that you validate your code before you ask for assistance. That's all.

  12. #12
    Join Date
    Aug 2004
    Location
    Toronto, Ontario (Canada)
    Posts
    100
    Quote Originally Posted by absolutmgd13 View Post
    ah, like a type of job interview?
    Yessss

  13. #13
    Join Date
    Jun 2006
    Location
    Boston, MA
    Posts
    383
    i can't believe you haven't posted it yet! lemme see.
    "Problems cannot be solved by the same level of thinking that created them.

  14. #14
    Join Date
    Aug 2004
    Location
    Toronto, Ontario (Canada)
    Posts
    100
    Sorry for the delay. I was waiting to get someone who said "go ahead"

    Here it is. She only gave me one site... http://attractionescort.com/

    Thank you, much appreciated.


    Michelle

  15. #15
    Join Date
    Jun 2006
    Location
    Boston, MA
    Posts
    383
    no validation errors, a couple of warnings but nothing that really needs attention.

    padding & margins could use better shorthand notation, but that's just a pet peeve of mine and compression would speed up the load time a bit, all in all it looks pretty good.

    "Problems cannot be solved by the same level of thinking that created them.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles