Number only validation

[webiter]

I am trying to get the preg_match '/[^0-9]/' thing below to validate or clear number only entries into a phone field. Am I on the right track as currently I cannot get it to work?

public function validatePhone($phoneVal, $phoneName) {
        if (strlen($phoneVal) <= 0) {
            $this->setError($phoneName, "Phone Number Required");
        } else if (!preg_match('/[^0-9]/', '',$phoneVal)) {
            $this->setError($phoneName, "Valid Phone Number Required");
        }
    } 

<p><label>Phone: <span class="required">Required</span>
          <input type="text" name="phone" class="textfield" value="<?php echo htmlentities($phone); ?>" />
          </label><span class="errors"><?php echo $phoneErr ?></span></p>

Thanks in advance for your oversight.

[chrisranjana]

Try

} else if (preg_match('/[^0-9]/', $phoneVal)) {

[NogDog]

If you just want to validate that a string contains only digits:

if(ctype_digit($string)) {
  // good
} else {
  // bad
} 

[webiter]

Thanks guys, that has resolved the issue. I discovered that

} else if (!is_numeric ($phoneVal)) {

also does the job.

In the circumstances which is the better, the !is_numeric or the preg_match approach ?

Also, what impact does the ! have in/out such code ?

[NogDog]

"!" is essentially the same as "false ==". It inverts the Boolean result of what it precedes, so if is_numeric() returns false, then ! is_numeric() returns true; while if is_numeric() returns true, then ! is_numeric() returns false.

[webiter]

Thanks for the lesson in opposites. Great answer.

[chrisranjana]

http://php.net/manual/en/function.is-numeric.php

........ +0123.45e6 is a valid numeric value. Hexadecimal notation (0xFF) is allowed too ......

so not sure whether is_numeric is sufficient for validating phone numbers containing only numbers, I would go with preg_match.

[NogDog]

http://php.net/manual/en/function.is-numeric.php



so not sure whether is_numeric is sufficient for validating phone numbers containing only numbers, I would go with preg_match.

Or ctype_digit(), which will be more efficient if that's all you need to test for.

[masterwin]

Hi

is_numeric is not work, because it gives true for "6.5" too

so its best with preg_match only

Let me know if any issues

Thanks
DS

[NogDog]

Hi

is_numeric is not work, because it gives true for "6.5" too

so its best with preg_match only

Let me know if any issues

Thanks
DS

Or ctype_digit(), which will be more efficient if that's all you need to test for.

[chrisranjana]

Deleted

[chrisranjana]

"!" is essentially the same as "false ==". It inverts the Boolean result of what it precedes, so if is_numeric() returns false, then ! is_numeric() returns true; while if is_numeric() returns true, then ! is_numeric() returns false.

Good ctype is good. I mean "late realization is always good"