Javascript problem with alert box

[RedPitbull]

I have this pice of code:

	function validator() {
	var l1 = document.calculation.l1.value;
	var l2 = document.calculation.l2.value;
	var right = document.calculation.right.value;
	 
 
if (l1 == null || l1 == "") alert("error ");
else if (l1 == null || l2 == "") alert("error");
else if (l1 == null || right == "") alert("error");
else if (right == 1) { alert("Correct"); }
 
  else { alert("Incorrect incorect"); } 
 
return false;
};

In Firefox is ok, but in Chrome the alert box is displayed before pressing the Submit button from my form. What can be wrong here?

[JMRKER]

What does your <form> tag look like?
Might need to be

<form name="myForm" action="???" method="post" onsubmit="return validator()">

Might try changing the following (I'm not sure I understand your logic or needs here):

var flag = true;
  if (l1 == null || l1 == "") { flag=false; alert("error "); }
  if (l2 == null || l2 == "") { flag=false; alert("error"); }
  if (right == null || right == "") { flag=false; alert("error"); }
  if ((flag == true) && (right == 1)) { alert("Correct"); }
  if (flag == false) { alert("Incorrect incorect"); } 

  return flag;