www.webdeveloper.com
Results 1 to 8 of 8

Thread: Code repeats itself

  1. #1
    Join Date
    Dec 2010
    Posts
    65

    Code repeats itself

    Ok, so I'm progamming a game again, and Here is the trouble I am havving.

    Every time I push right as the box is falling, it doubles in speed. if I hold down the right arrow, it continues to go faster until it hits the ground. how can i stop the speed from doubling?




    HTML Code:
    <html>
    <head>
    <script type="text/javascript">
    var guy;
    var ground;
    var guytop=25;
    var guyleft=25;
    var groundtop=400;
    var groundleft=0;
    
    
    function animate(e){
    guy=document.getElementById('guy');
    ground=document.getElementById('ground');
    
    if(!e){
    	e=window.event;
    }
    if(e.keyCode===39){
    	guyleft +=5;
    	guy.style.left = guyleft + 'px';
    }
    
    
    gravityInt();
    }
    
    
    function gravity(){
    	if((guytop)+50 < groundtop){
    		guytop +=5;
    		guy.style.top = guytop + 'px';
    	
    }
    
    }
    
    function gravityInt(){
    	setInterval('gravity()', 50);
    }
    document.onkeydown=animate;
    </script>
    </head>
    <body onload="animate()">
    <div id="guy" style="height: 50px; width: 50px; top: 25px; left: 25px; background: red; border: 1px solid black; position: absolute;"></div>
    <div id="ground" style="height: 25px; width: 500px; background: gray; border: 1px solid black;
    position: absolute; left: 0; top: 400;"></div>


    Also, I am making a map array. It would be something like this.


    var map=new Array=(a,a,a,a,a,
    a,a,a,x,a,
    a,a,a,a,a);

    And then let's say i put my character in that array and when he collides with "x" I want something to happen. But I'm having trouble with that. I tried doing it like this.

    if(guy >= map[8] && guy <= map[8]){
    //something happens here
    }


    but nothing does, the only way I can get something to happen is to write it like this which is no good.

    if(guy < map[8]){
    //something happen
    }

    Help is appreciated!

  2. #2
    Join Date
    Oct 2006
    Posts
    939
    You are calling gravityInt() and then setting Interval each time you click right.
    Either clearInterval or seperate the codes

    PHP Code:
    <html>
    <
    head>
    <
    script type="text/javascript">
    var 
    guy;
    var 
    ground;
    var 
    guytop=25;
    var 
    guyleft=25;
    var 
    groundtop=400;
    var 
    groundleft=0;


    function 
    animate(e){

    if(!
    e){    e=window.event;}
    if(
    e.keyCode===39){
        
    guyleft +=5;
        
    guy.style.left guyleft 'px';
    }


    }


    function 
    gravity(){
        if((
    guytop)+50 groundtop){    guytop +=5;    guy.style.top guytop 'px'; }
    }

    function 
    gravityInt(){guy=document.getElementById('guy');
    ground=document.getElementById('ground');
        
    setInterval('gravity()'50);}

    document.onkeydown=animate;
    </
    script>
    </
    head>
    <
    body onload="gravityInt();
    "
    >
    <
    div id="guy" style="height: 50px; width: 50px; top: 25px; left: 25px; background: red; border: 1px solid black; position: absolute;"></div>
    <
    div id="ground" style="height: 25px; width: 500px; background: gray; border: 1px solid black;
    position: absolute; left: 0; top: 400;"
    ></div>

    </
    body></html

  3. #3
    Join Date
    Dec 2010
    Posts
    65
    Thanks for your reply. Do You think, you coudl tell me why I can't get collision to work with this grid array?

  4. #4
    Join Date
    Oct 2006
    Posts
    939
    Your map is filled with undefined variables. if it is a string you need to quote them

    var map='a,a,a,a,a,a,a,a,x,a,a,a,a,a,a'; map=map.split(',');

  5. #5
    Join Date
    Dec 2010
    Posts
    65
    NO they aren't undefined. I didn't post what I defined them as. but above them I posted var a=<img src="" /> and so on. So How would I say if guy collides into a stop. or die

  6. #6
    Join Date
    Dec 2010
    Posts
    65
    bump

  7. #7
    Join Date
    Oct 2006
    Posts
    939
    Quote Originally Posted by pdiddles03 View Post
    NO they aren't undefined. I didn't post what I defined them as. but above them I posted var a=<img src="" /> and so on. So How would I say if guy collides into a stop. or die
    We can't read your mind, only your code. If there is relevant code you need to paste all of it.

  8. #8
    Join Date
    Dec 2010
    Posts
    65
    Stop being a jerk and read what I wrote. You don't need the variables. I explained I wanted a collision once my character moves to x. If you don't have the answer for me don't reply. I can't read the mind of morons to find answers.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.21556 seconds
  • Memory Usage 2,924KB
  • Queries Executed 15 (?)
More Information
Template Usage (35):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_html
  • (1)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (8)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (8)postbit
  • (8)postbit_onlinestatus
  • (8)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates