www.webdeveloper.com
Results 1 to 3 of 3

Thread: function runs at browser reload.

  1. #1
    Join Date
    Jul 2012
    Posts
    12

    function runs at browser reload.

    I'm tinkering with css and javascript today but I've encountered a small problem.

    Here's a snippet of my code:

    PHP Code:
    var genres = new Array();
    var 
    genre1 = new Array();
    var 
    genre2 = new Array();
    var 
    genre3 = new Array();
        

    window.onload = function(){
        var 
    addButton document.getElementById("addButton");
        
    addButton.onclick handleAddButton;
        
        var 
    genre1 document.getElementById("genre1");
        
    genre1.onclick showGenreValues("genre1");
        
    }

    function 
    handleAddButton(){
        ...
    }

    function 
    pushValues(songInfoString,songGenre){
        ...
    }

    function 
    showGenreValues(genre){
        
    alert("Showing: " genre);

    I left out the content of functions because they are not part of the problem.

    the problem resides in

    PHP Code:
    function showGenreValues(genre){
        
    alert("Showing: " genre);

    this function should only be ran when pushing a subitem in a menu. Here's the snippet of the menu:

    Code:
    <nav>
     <ul>
       <li><a href="">Link1</a>
          <ul id="link1">
    	 <li id="genre1"><a href="">Genre1</a></li>
    	 <li id="genre2"><a href="">Genre2</a></li>
      	 <li id="genre3"><a href="">Genre3</a></li>
          </ul>
       </li>
       <li id="link2"><a href="">Link2</a></li>
       <li id="link3"><a href="">Link3</a></li>
       <li id="link4"><a href="">Link4</a></li>
       <li id="link5"><a href="">Link5</a></li>
     </ul>
    </nav>
    Now the showGenreValues function runs like it should when I press it in a browser. Problem is, when I hit reload I get the alert sent by the function as well, which I shouldn't.

    Anyone who knows how this is possible?

    Cheers.

  2. #2
    Join Date
    Jul 2007
    Posts
    386
    That is happening because you are passing an argument to the function.

    Try it like this:
    Code:
    var genre1 = document.getElementById("genre1");
    genre1.onclick = function(){showGenreValues("genre1")};

  3. #3
    Join Date
    Jul 2012
    Posts
    12
    Quote Originally Posted by SparoHawk View Post
    That is happening because you are passing an argument to the function.

    Try it like this:
    Code:
    var genre1 = document.getElementById("genre1");
    genre1.onclick = function(){showGenreValues("genre1")};

    Worked like a charm, thank you!

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.33683 seconds
  • Memory Usage 2,856KB
  • Queries Executed 15 (?)
More Information
Template Usage (35):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (3)bbcode_code
  • (2)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates