[RESOLVED] Change image

**Nomistake** · 08-03-2012 08:02 AM

Hi,

Just new to JavaScript and I'm trying the following:

I include my javascript file:

HTML Code:

<script type="text/javascript" src="javascript/script.js"></script>

In my html code i have an image:

HTML Code:

<img id="nu" class="website" src="images/website_images/nu.png" />

The script file contains the following:

Code:

var nu_image = document.getElementById("nu");

function test() {
window.alert('test!');
};
nu_image.onclick = test();

Why isnt this working?

When i use this it works:

HTML Code:

<img id="nu" class="website" src="images/website_images/nu.png" onclick="test();" />

but i want the onclick etc in the javascript page, not between the html code...

anyone any suggestions?

Thanx!

**vwphillips** · 08-03-2012 08:33 AM

Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">

<head>
  <title></title>
</head>

<body>
<img id="nu" class="website" src="images/website_images/nu.png" />
<script type="text/javascript">
/*<![CDATA[*/
var nu_image = document.getElementById("nu");   // the image must exist before it is referenced

function test() {
window.alert('test!');
};
nu_image.onclick = test;  // no ()

// use an anonomus function
//nu_image.onclick = function(){ test();  }
/*]]>*/
</script></body>

</html>

**Nomistake** · 08-03-2012 08:48 AM

Vic,
Thank you very much.
I' had already been playing calling the function with or without ().

But yes, i called the script before the image was created.

Now i have put the link to the script at the end of the code and it works fine now!!!
Glad to have it sorted out!

Thanks!

Is it an advantage to use a anonomus function ?

**Gudlife** · 08-03-2012 09:48 AM

just enclose your script in a window.onload to be shure the image and it's id exist before loading the script.

**vwphillips** · 08-03-2012 11:01 AM

Is it an advantage to use a anonomus function

it is better practice

Thread: [RESOLVED] Change image

Thread Tools

Display

[RESOLVED] Change image

or even easyer...

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions