[RESOLVED] About date validation(regexp)

[ARNEBEAR]

I want to validate whether the date(day) user input is correct format or not, but the code seems wrong, it displays "invalid" all time...


in js:

function validateCc3() {
	if (document.loginform.cc3.value == "") {
		errorMessage(document.loginform.cc3, "can't be blank");
		return false;
	}
	else {
		var cc3_regexp = /0[1-9]|[12][0-9]|3[01]/;
		var cc3 = document.loginform.cc1.value;
		var valid = cc3_regexp.exec(cc1);
		if (!valid) {
		errorMessage(document.loginform.cc3, "invalid");
		return false;
		}
		else {
		removeErrorMessage(document.loginform.cc3);
		return true; 		}
	}
}

html:

<input class="requiredshort" type="text" id="cc3" name="cc3" maxlength="2" size="4" onblur="validateCc3();">

[rebelweb2007]

If you are worried about the correct format, you may want to use a selection option, that way you can handle the format easier, trying to have them input the correct format, may cause some bad data to be entered. Let's face no matter how smart we think we are as developers. The user can always come up with weird scenarios and may end up figuring out a way to enter bad data into your form. Also, in some cases JavaScript is turned off what happens then, do you have a backup plan? You should use a server-side language to do this, so the client can't turn off your validation if you need to use a text field for the date.

[ARNEBEAR]

If you are worried about the correct format, you may want to use a selection option, that way you can handle the format easier, trying to have them input the correct format, may cause some bad data to be entered. Let's face no matter how smart we think we are as developers. The user can always come up with weird scenarios and may end up figuring out a way to enter bad data into your form. Also, in some cases JavaScript is turned off what happens then, do you have a backup plan? You should use a server-side language to do this, so the client can't turn off your validation if you need to use a text field for the date.

really thanks for your suggestions. However, I am doing my homework.. so ... this is what my teacher ask me to do- something about regular expression, SAD...

[bionoid]

Your regular expression seems to be working fine:

function validateCc3()
{
	if (/0[1-9]|[12][0-9]|3[01]/.test(document.loginform.cc3.value)) {

		alert('Valid!');

	} else {

		alert('Invalid!');

	}
}

In the original code I did see a few inconsistencies, like variable names and what field you are querying:

function validateCc3() {
	if (document.loginform.cc3.value == "") {
		errorMessage(document.loginform.cc3, "can't be blank");
		return false;
	}
	else {
		var cc3_regexp = /0[1-9]|[12][0-9]|3[01]/;
		var cc3 = document.loginform.cc1.value;
		var valid = cc3_regexp.exec(cc1);
		if (!valid) {
		errorMessage(document.loginform.cc3, "invalid");
		return false;
		}
		else {
		removeErrorMessage(document.loginform.cc3);
		return true; 		}
	}
}