www.webdeveloper.com
Results 1 to 5 of 5

Thread: Simple Show/Hide Button

  1. #1
    Join Date
    Sep 2012
    Posts
    4

    Simple Show/Hide Button

    Hi. Sorry but i'm not english so i can make some grammar mistakes. I've written this code:
    HTML Code:
    <?xml version="1.0" encoding="utf-8"?> 
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> 
    <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="pl" lang="pl"> 
    <head> 
    	<title>Lirians</title> 
    	<script type="text/javascript" charset="UTF-8" src="skrypty.js"></script>
    	<script type="text/javascript" charset="UTF-8" src="jquery-1.3.2.js"></script>
    	<script type="text/javascript" src="http://koval.ovh.org/skrypty/getebc.js"> </script>
    </head> 
    <body>
    	
    	<div id="spany"> 
    		<span class="ukryj">Ukryj Tekst</span><br />
    		<span>Lorum Ipsum </span>
                    <span class="ukryj">Ukryj Tekst</span><br />
    		<span>Lorum Ipsum </span>
    	</div>
    	
    	<script type="text/javascript" charset="UTF-8">
    		document.getElementsByClassName('ukryj').onclick = ukrywaj;
    		
    		function ukrywaj() {
    			var zmienna = this.nextSibling.nextSibling.style.display;
    			if (zmienna == 'inline') {zmienna = 'none';}
    			else {zmienna = 'inline';}
    		}
    	</script>
    
    </body>
    </html>
    My question is:
    - Code is wrong because of "display of undefined". I have span, br and span so first span is like a button and it has to show or hide a next span. I'm beginner but it seems to be a simple mistake. Please help.

  2. #2
    Join Date
    Jun 2004
    Location
    Portsmouth UK
    Posts
    2,709
    Code:
    <?xml version="1.0" encoding="utf-8"?>
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="pl" lang="pl">
    <head>
    	<title>Lirians</title>
    	<script type="text/javascript" charset="UTF-8" src="skrypty.js"></script>
    	<script type="text/javascript" charset="UTF-8" src="jquery-1.3.2.js"></script>
    	<script type="text/javascript" src="http://koval.ovh.org/skrypty/getebc.js"> </script>
    </head>
    <body>
    
    	<div id="spany">
    		<span id="ukryj0">Ukryj Tekst</span><br />
    		<span>Lorum Ipsum </span>
                    <span id="ukryj1">Ukryj Tekst</span><br />
    		<span>Lorum Ipsum </span>
    	</div>
    
    	<script type="text/javascript" charset="UTF-8">
    //		not all browsers support document.getElementsByClassName
     for (var z0=0;document.getElementById('ukryj'+z0);z0++){
      document.getElementById('ukryj'+z0).onclick = ukrywaj;
     }
    
    		function ukrywaj() {
    			var zmienna = this.nextSibling.nextSibling;
                zmienna.style.display=zmienna.style.display!='none'?'none':'inline';
    		}
    	</script>
    
    </body>
    </html>
    Vic

    God loves you and will never love you less.

    http://www.vicsjavascripts.org/Home.htm
    If my post has been useful please donate to http://www.operationsmile.org.uk/

  3. #3
    Join Date
    Sep 2012
    Posts
    4
    It doesn't work. I'm using Chrome and there is:
    "Uncaught TypeError: Cannot read property 'display' of undefined"

  4. #4
    Join Date
    Jun 2004
    Location
    Portsmouth UK
    Posts
    2,709
    that is because you have white space between the <br> and span

    use HTML

    Code:
    	<div id="spany">
    		<span id="ukryj0">Ukryj Tekst</span><br /><span>Lorum Ipsum </span>
            <span id="ukryj1">Ukryj Tekst</span><br /><span>Lorum Ipsum </span>
    	</div>
    Vic

    God loves you and will never love you less.

    http://www.vicsjavascripts.org/Home.htm
    If my post has been useful please donate to http://www.operationsmile.org.uk/

  5. #5
    Join Date
    Sep 2012
    Posts
    4
    You don't know how much i'm happy that it's working right now. I've forgotten about whitespace Thx

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.35172 seconds
  • Memory Usage 2,881KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (1)bbcode_html
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (5)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates