[RESOLVED] Dynamic For Loop from amount of files in folder

[BenSeagrave]

I'm trying to create a dynamic for loop that echos all the images in a folder.

I'm using the query string to switch folders for the images. If you go to http://btseagrave.co.uk/ink/index.ph...&artist=bianca you will see what I mean. On the artists page a file called gallery.inc.php is included which displays the images depending on which artist page its on. Here is the gallery.inc.php so far, I'm not sure why it isn't working. Any suggestions?

<div id="gallery">
<?php

$directory = "images/$cartist/thumb/";
if (glob($directory . "*.jpeg") != false)
{
    $filecount = count(glob($directory . "*.jpeg"));
}
else
{
    $filecount = 0;
}

$cartist = $_GET['artist'];
for($i=1;$i<=$filecount;$i++) {
    echo "<a href='#'><img src='images/$cartist/thumb/$i.jpeg' alt='$cartist' /></a>";
}

?>
</div>

the thumbnail images that I want to display are in images/*artists*/thumb (e.g images/bianca/thumb/1.jpeg & images/bryan/thumb/1.jpeg)

Also I don't have to stick to this method, if theres a better method please share!

[NogDog]

How about something like this:

$cartist = basename($_GET['artist']); // prevent directory traversal attacks
$directory = "images/$cartist/thumb/";
if(file_exists($directory) and is_dir($directory)) {
    $files = glob($directory . "*.jpeg");
    if(is_array($files)) {
        foreach($files as $file) {
            echo "<a href='#'><img src='".htmlspecialchars($file)."' alt='".
                 htmlspecialchars($cartist)."' /></a>";
        }
    }
} 

[BenSeagrave]

That works great, thank you!

I now have one more problem though:
I'm trying to use a Lightbox which requires the anchor around the image to link to the actual image not the thumbnail. The anchor needs to link to the same file but in a big folder instead of thumb folder. (e.g. images/bianca/big/1.jpeg instead of images/bianca/thumb/1.jpeg). I would just change the directory variable but I still need to print out the thumbnails on the page.

Know a solution?

Thanks!

[NogDog]

How about a second variable for the full-sized directory, then just pop that in where you need it.

[BenSeagrave]

How would I do that? Because the directory is used in the foreach loop so how would I change it?

[BenSeagrave]

Would I have to make another foreach loop?

[NogDog]

Well, assuming you use some sort of consistent naming convention, I might do:

$cartist = basename($_GET['artist']); // prevent directory traversal attacks
$imageDir = "images/$cartist";
$thumbDir = "$imageDir/thumbs"; 
if(
    file_exists($imageDir) and
    is_dir($imageDir)      and
    file_exists($thumbDir) and
    is_dir($thumbDir))
{
    $curDir = getcwd();
    chdir($imageDir);
    $files = glob("*.jpeg");
    if(is_array($files)) {
        foreach($files as $file) {
            printf(
                "<a href='%s/%s'><img src='%s/%s' alt='%s' /></a>\n",
                htmlspecialchars($imageDir),
                htmlspecialchars($file),
                htmlspecialchars($thumbDir),
                htmlspecialchars($file),
                htmlspecialchars($cartist)
            );
        }
    }
}