Strict Standards: Only variables should be passed by reference in

[wdas]

It is strange error (first time I've evern seen this kind of notice)
so i've looked over internet and i've found nothing so far...
here is the code that is causing it:

function mkthumb($src, $Twidth) {
      $name = basename(strtolower($src));
      $F = end(explode(".", $name));
      if($F == "jpg" OR $F == "jpeg") {
         $img = imagecreatefromjpeg($src);
      }
      else if($F == "png") {
         $img = imagecreatefrompng($src);
      } else {
                        $img = imagecreatefromgif($src);
                }

at the line $F = end (explode....
seems to be the problem
So any suggestions?

[NogDog]

See the manual page for end(), and notice in the description section that the array argument is passed by reference (indicated by the "&"). In your code you are passing the result of explode(), which while it is an array (assuming it succeeds), there is no variable to pass as a reference. Therefore, you need an intermediate step to create an array variable (and ideally should verify it is, in fact, a successful assignment before assuming it's okay):

      $name = basename(strtolower($src));
      $exploded = explode(".", $name);
      if($exploded === false) { throw new Exception("Oops!"); } // or whatever you want to do
      $F = end(exploded)); 

[NogDog]

PS: Personally, I'd probably use getimagesize() to figure out what type of image it is.

[wdas]

Well i toke your advice,and your code , but now it's not "Strik Standards" it's Fatal error with same infonly variables should be passed at....
it's at the same line

$F = end(exploded));

:S

actually it worked ,just had to add the $ symbol and remove one )
ty , problem solved!

[ZABI]

using strtolower is a good idea while checking for file extensions in case if extension is JPG or jPg etc...

[NogDog]

using strtolower is a good idea while checking for file extensions in case if extension is JPG or jPg etc...

Another reason I like getimagesize(), as it looks at the actual file contents, not whatever name a user happened to assign to it.

[ZABI]

yea, this way we can also check for minimum or maximum image size limit.