www.webdeveloper.com
Results 1 to 7 of 7

Thread: Why doesn't my getAttribute work ?

  1. #1
    Join Date
    Sep 2012
    Posts
    2

    Why doesn't my getAttribute work ?

    <html>
    <head>
    <script type="text/javascript>
    var a = document.getElementsByTagName("img").getAttribute("src");
    alert(a);
    </script>
    <body>
    <img src="www.google.com" alt="picture"/>
    </body>
    </html>

    I want the browser to alert the src of the picture (www.google.com) but it never works !
    Help much appreciated
    Thanks in advance,
    B.W

  2. #2
    Join Date
    Nov 2010
    Posts
    1,276
    getElementsByTagName returns a collection (even if that collection is only one item, and the contents should be accessed by array notation.

    getAttribute is only really necessary for non-standard attributes. The standard ones (like src) can be accessed directly:
    Code:
    var a = document.getElementsByTagName("img")[0].src;

  3. #3
    Join Date
    Jan 2004
    Location
    chertsey, a small town s.w. of london, england.
    Posts
    1,867
    Hi there brucewayne,

    and a warm welcome to these forums.

    Further to what xelawho has said, there are some other reasons for your script failure.

    You are missing a closing double quote here...
    <script type="text/javascript>
    ...which means that the script will never run.

    Although you can set this...
    var a=document.getElementsByTagName('img');
    ...before the page loads, you cannot access the actual elements until after.

    This following will resolve these issues...
    Code:
    <script type="text/javascript">
    
      var a=document.getElementsByTagName('img');
    
    function init(){
    
    for(c=0;c<a.length;c++) {
       alert(a[c].getAttribute('src'));
      }
     }
       window.addEventListener?
       window.addEventListener('load',init,false):
       window.attachEvent('onload',init);
    
    </script>
    
    coothead

  4. #4
    Join Date
    Nov 2010
    Posts
    1,276
    woops. never even looked that far. nice one, coothead

  5. #5
    Join Date
    Jan 2004
    Location
    chertsey, a small town s.w. of london, england.
    Posts
    1,867
    Hi there xelawho,

    thanks for the thumbs-up.

    coothead

  6. #6
    Join Date
    Sep 2012
    Posts
    2

    Now what if..

    Now, I don't understand all that window.onload code. So, to make it simpler for me, I'd like to use butttons.

    HTML:

    <img src="www.google.com" alt="picture"/>
    <input type="button" onclick="alertit()"/>

    Javascript:

    <script type="text/javascript">
    function alertit() {
    var a = document.getElementsByTagName("img")[0].getAttribute("src");
    alert(a);
    }

    Why doesn't this work either ?

  7. #7
    Join Date
    Jan 2004
    Location
    chertsey, a small town s.w. of london, england.
    Posts
    1,867
    Quote Originally Posted by brucewayne View Post
    Why doesn't this work either ?
    Your code does not have a closing script tag.

    coothead

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.12440 seconds
  • Memory Usage 2,902KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates