www.webdeveloper.com
Results 1 to 4 of 4

Thread: MySQL update is not working

  1. #1
    Join Date
    Oct 2012
    Posts
    15

    MySQL update is not working

    I'm trying to edit a MySQL row and its not working.
    This is the the file that updates the changes

    Help anybody?

    <?php

    include "database-connection.php";
    //get id column
    $store_id = $_GET['id'];

    $store = $_POST['storeNumberUpdate'];

    $result = mysql_query("UPDATE Stores SET Store='$store' WHERE id='$store_id'");

    header("location:edit-delete-store.php");
    ?>

  2. #2
    Join Date
    Mar 2009
    Posts
    452
    try $result = mysql_query("UPDATE Stores SET Store='$store' WHERE id='$store_id'") or die(mysql_error());

    passing the values from GET/POST/REQUEST etc... directly in sql query can increase the risk of SQL Injection, you must perform some kind of validation, or atleast mysql_real_escape_string if values are string or (int)$_GET['id'] if integer.

  3. #3
    Join Date
    Oct 2012
    Posts
    15
    Yeah, still not editing or working

    Here is the edit form

    <!DOCTYPE HTML>
    <html>
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <title>Untitled Document</title>
    <link rel="stylesheet" href="admin-style.css" type="text/css" />
    </head>

    <body id="edit-delete-store">
    <?php
    include "header.php"
    ?>

    <div class="top-content-page"></div>
    <div class="main-page">
    <?php
    include "database-connection.php";




    $store_id = $_GET['id'];
    $result = mysql_query("SELECT * FROM Stores WHERE id = '$store_id'");
    $row = mysql_fetch_array($result);




    ?>

    <h2>Edit Store</h2>


    <div class="border">

    <div class="form">
    <form method="post" action="change-store.php">
    <input type="hidden" name="id" value="<?php echo $row['id']; ?>" />
    <div class="line">
    <div class="line-label">
    <label for="storeNumberUpdate"><strong>Store Number:</strong></label>
    </div>
    <input type="text" name="storeNumberUpdate" value="<?php echo $row['Store']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storeEmail"><strong>Email:</strong></label>
    </div>
    <input type="text" name="storeEmailUpdate" value="<?php echo $row['Email']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storeAddress"><strong>Address:</strong></label>
    </div>
    <input type="text" name="storeAddressUpdate" value="<?php echo $row['Address']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storePhoneNumber"><strong>Phone Number:</strong></label>
    </div>
    <input type="text" name="storePhoneNumberUpdate" value="<?php echo $row['Phone']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storeManger"><strong>Manager:</strong></label>
    </div>
    <input type="text" name="storeManagerUpdate" value="<?php echo $row['Manager']; ?>" />
    </div>
    <input type="submit" name="Edit" value="Edit" />
    </form>

    </div>
    <?php
    mysql_close($con);
    ?>

    </div>
    <footer>
    <p class="footer-text">Horizon Holding &copy; Copyright. All Rights Reserved.</p>
    </footer>


    </div>



    </body>
    </html>

  4. #4
    Join Date
    Oct 2012
    Posts
    15

    Stil wont work

    still not working

    here is the edit form if this is the issue

    help anybody?



    <!DOCTYPE HTML>
    <html>
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <title>Untitled Document</title>
    <link rel="stylesheet" href="admin-style.css" type="text/css" />
    </head>

    <body id="edit-delete-store stores">
    <?php
    include "header.php"
    ?>

    <div class="top-content-page"></div>
    <div class="main-page">
    <?php
    include "database-connection.php";




    $store_id = $_GET['id'];
    $result = mysql_query("SELECT * FROM Stores WHERE id = '$store_id'");
    $row = mysql_fetch_array($result);




    ?>

    <h2>Edit Store No: <?php echo $row['Store']; ?></h2>


    <div class="border">

    <div class="form">
    <form method="post" action="change-store.php ">
    <input type="hidden" name="id" value="<?php echo $row['id']; ?>" />
    <div class="line">
    <div class="line-label">
    <label for="storeNumberUpdate"><strong>Store Number:</strong></label>
    </div>
    <input type="text" name="storeNumberUpdate" value="<?php echo $row['Store']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storeEmail"><strong>Email:</strong></label>
    </div>
    <input type="text" name="storeEmailUpdate" value="<?php echo $row['Email']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storeAddress"><strong>Address:</strong></label>
    </div>
    <input type="text" name="storeAddressUpdate" value="<?php echo $row['Address']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storePhoneNumber"><strong>Phone Number:</strong></label>
    </div>
    <input type="text" name="storePhoneNumberUpdate" value="<?php echo $row['Phone']; ?>" />
    </div>
    <div class="line">
    <div class="line-label">
    <label for="storeManger"><strong>Manager:</strong></label>
    </div>
    <input type="text" name="storeManagerUpdate" value="<?php echo $row['Manager']; ?>" />
    </div>
    <input type="submit" name="Edit" value="Edit" />
    </form>

    </div>
    <?php
    mysql_close($con);
    ?>

    </div>
    <footer>
    <p class="footer-text">Horizon Holding &copy; Copyright. All Rights Reserved.</p>
    </footer>


    </div>



    </body>
    </html>

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.15990 seconds
  • Memory Usage 2,877KB
  • Queries Executed 15 (?)
More Information
Template Usage (32):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (4)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates