www.webdeveloper.com
Results 1 to 5 of 5

Thread: login form error

  1. #1
    Join Date
    Nov 2012
    Posts
    6

    login form error

    I'm having trouble with my login form and I'm not quite sure why. The code is not passing the
    PHP Code:
    if($login_check 0){ 
    or while loop and is going to the else statement instead. I even tried taking the password hashing out and putting a generic password into my database but it still says "No match in our records, try again".

    Here's the php.
    PHP Code:
    <?php
    if ($_POST['email']) {
        
    //Connect to the database through include
        
    include_once "scripts/connect_to_mysql.php";
        
    $email $_POST['email'];
        
    $email mysql_real_escape_string($email);
        
    $password $_POST['password'];
        
    $password $password;
        
    // Make query and then register all database data 
        
    $sql mysql_query("SELECT * FROM members WHERE email='$email' AND password='$password'"); 
        
    $login_check mysql_num_rows($sql);
        if(
    $login_check 0){ 
            while(
    $row mysql_fetch_array($sql)){ 
                
    // Get member ID into a session variable
                
    $id $row["id"];   
                
    session_register('id'); 
                
    $_SESSION['id'] = $id;
                
    // Get member username into a session variable
                
    $username $row['username'];   
                
    session_register('username'); 
                
    $_SESSION['username'] = $username;
                
    // Update last_log_date field for this member now
                
    mysql_query("UPDATE members SET lastlogin=now() WHERE id='$id'"); 
                
    // Print success message here if all went well then exit the script
                
    header("location: member_profile.php?id=$id"); 
                exit();
            } 
    // close while
        
    } else {
        
    // Print login failure message to the user and link them back to your login page
          
    print '<font color="red">No match in our records, try again </font><br />
        <a href="login2.php">Click here</a> to go back to the login page.'
    ;
          exit();
        }
    }
    // close if post
    ?>

    And here's is the form.
    Code:
    <div>
    Please log in.
    	<form action="login2.php" method="post">
    	<input type="text" name="email" id="email" placeholder="Email"/><br />
        <input type="password" name="password" id="password" placeholder="Password"/><br />
        <input type="submit" value="Login" />
    	</form>
    </div>

  2. #2
    Join Date
    Aug 2012
    Posts
    155
    What is the format of your passwords in your database (md5 or sha1 or plain text)??

    I see some problems in your code but not that they would cause you problems as such, just unnecessary duplicated code
    PHP Code:
    <?php
    if ($_POST['email']) {
        
    //Connect to the database through include
        
    include_once "scripts/connect_to_mysql.php";
        
    $email $_POST['email'];
        
    $email mysql_real_escape_string($email);
        
    $password mysql_real_escape_string($_POST['password']);
        
    // Make query and then register all database data 
        
    $sql mysql_query("SELECT * FROM members WHERE email='$email' AND password='$password'"); 
        
    $login_check mysql_num_rows($sql);
        if(
    $login_check 0){ 
            while(
    $row mysql_fetch_array($sql)){ 
                
    // Get member ID into a session variable
                
    $_SESSION['id'] = $row["id"];
                
    // Get member username into a session variable
                
    $_SESSION['username'] = $row['username'];   
                
    // Update last_log_date field for this member now
                
    mysql_query("UPDATE members SET lastlogin=now() WHERE id='".$_SESSION['id']."'"); 
                
    // Print success message here if all went well then exit the script
                
    header("location: member_profile.php"); //$id not needed as already stored in a session for use on other pages
                
    exit();
            } 
    // close while
        
    } else {
        
    // Print login failure message to the user and link them back to your login page
          
    print '<font color="red">No match in our records, try again </font><br />
        <a href="login2.php">Click here</a> to go back to the login page.'
    ;
          exit();
        }
    }
    // close if post
    ?>
    Echo out your $sql to make sure it looks correct and if so, run in phpmydamin to make sure you get no errors.

  3. #3
    Join Date
    Mar 2009
    Posts
    452
    use mysql_error() to find out if there is any mysql error

    rest if the code looks fine in a quick look.

  4. #4
    Join Date
    Nov 2012
    Posts
    6
    Thanks for feedback. Was an error on register.php with password hashing. Thanks for the good looks.

  5. #5
    Join Date
    Mar 2014
    Posts
    5
    hi ershy, i have similar problem, how did you solved the password hashing error in register.php

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.14294 seconds
  • Memory Usage 2,894KB
  • Queries Executed 13 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_code
  • (3)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (5)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates