www.webdeveloper.com
Results 1 to 5 of 5

Thread: login form error

Hybrid View

  1. #1
    Join Date
    Nov 2012
    Posts
    6

    login form error

    I'm having trouble with my login form and I'm not quite sure why. The code is not passing the
    PHP Code:
    if($login_check 0){ 
    or while loop and is going to the else statement instead. I even tried taking the password hashing out and putting a generic password into my database but it still says "No match in our records, try again".

    Here's the php.
    PHP Code:
    <?php
    if ($_POST['email']) {
        
    //Connect to the database through include
        
    include_once "scripts/connect_to_mysql.php";
        
    $email $_POST['email'];
        
    $email mysql_real_escape_string($email);
        
    $password $_POST['password'];
        
    $password $password;
        
    // Make query and then register all database data 
        
    $sql mysql_query("SELECT * FROM members WHERE email='$email' AND password='$password'"); 
        
    $login_check mysql_num_rows($sql);
        if(
    $login_check 0){ 
            while(
    $row mysql_fetch_array($sql)){ 
                
    // Get member ID into a session variable
                
    $id $row["id"];   
                
    session_register('id'); 
                
    $_SESSION['id'] = $id;
                
    // Get member username into a session variable
                
    $username $row['username'];   
                
    session_register('username'); 
                
    $_SESSION['username'] = $username;
                
    // Update last_log_date field for this member now
                
    mysql_query("UPDATE members SET lastlogin=now() WHERE id='$id'"); 
                
    // Print success message here if all went well then exit the script
                
    header("location: member_profile.php?id=$id"); 
                exit();
            } 
    // close while
        
    } else {
        
    // Print login failure message to the user and link them back to your login page
          
    print '<font color="red">No match in our records, try again </font><br />
        <a href="login2.php">Click here</a> to go back to the login page.'
    ;
          exit();
        }
    }
    // close if post
    ?>

    And here's is the form.
    Code:
    <div>
    Please log in.
    	<form action="login2.php" method="post">
    	<input type="text" name="email" id="email" placeholder="Email"/><br />
        <input type="password" name="password" id="password" placeholder="Password"/><br />
        <input type="submit" value="Login" />
    	</form>
    </div>

  2. #2
    Join Date
    Aug 2012
    Posts
    155
    What is the format of your passwords in your database (md5 or sha1 or plain text)??

    I see some problems in your code but not that they would cause you problems as such, just unnecessary duplicated code
    PHP Code:
    <?php
    if ($_POST['email']) {
        
    //Connect to the database through include
        
    include_once "scripts/connect_to_mysql.php";
        
    $email $_POST['email'];
        
    $email mysql_real_escape_string($email);
        
    $password mysql_real_escape_string($_POST['password']);
        
    // Make query and then register all database data 
        
    $sql mysql_query("SELECT * FROM members WHERE email='$email' AND password='$password'"); 
        
    $login_check mysql_num_rows($sql);
        if(
    $login_check 0){ 
            while(
    $row mysql_fetch_array($sql)){ 
                
    // Get member ID into a session variable
                
    $_SESSION['id'] = $row["id"];
                
    // Get member username into a session variable
                
    $_SESSION['username'] = $row['username'];   
                
    // Update last_log_date field for this member now
                
    mysql_query("UPDATE members SET lastlogin=now() WHERE id='".$_SESSION['id']."'"); 
                
    // Print success message here if all went well then exit the script
                
    header("location: member_profile.php"); //$id not needed as already stored in a session for use on other pages
                
    exit();
            } 
    // close while
        
    } else {
        
    // Print login failure message to the user and link them back to your login page
          
    print '<font color="red">No match in our records, try again </font><br />
        <a href="login2.php">Click here</a> to go back to the login page.'
    ;
          exit();
        }
    }
    // close if post
    ?>
    Echo out your $sql to make sure it looks correct and if so, run in phpmydamin to make sure you get no errors.

  3. #3
    Join Date
    Mar 2009
    Posts
    452
    use mysql_error() to find out if there is any mysql error

    rest if the code looks fine in a quick look.

  4. #4
    Join Date
    Nov 2012
    Posts
    6
    Thanks for feedback. Was an error on register.php with password hashing. Thanks for the good looks.

  5. #5
    Join Date
    Mar 2014
    Posts
    5
    hi ershy, i have similar problem, how did you solved the password hashing error in register.php

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles