Changing input before KeyCode == 13 was entered

[assaf.vilmovski]

Hi,

I am trying to re-assign a dom input element based on it's content after hitting the [enter] key.
thing is...the [enter] is executed ahead of the conditions. Confirm dialog works fine but I don't want to use any dialogs.

It's part of a chrome extension...

Here is my code:

document.onkeyup = returnKey;

function returnKey(evt)
{
var evt = (evt) ? evt : ((event) ? event : null);
var node = (evt.target) ? evt.target : ((evt.srcElement) ? evt.srcElement : null);

if ( node.value == 'fi' ) { node.value = "כן"; }
if ( node.value == 'kt' ) { node.value = "לא"; }

}

I want to change the value of node.value,
only after that, [enter] should be executed. ( with updated value ).

Thanks,
Asaph.

[assaf.vilmovski]

conditions should look like that ( just to show you the basic logic of what I want to achieve. )

if ( evt.keyCode == 13 )
{
if ( node.value == 'fi' ) { evt.srcElement.value = "כן"; }
if ( node.value == 'kt' ) { evt.srcElement.value = "לא"; }
}

but it's not working.

thanks

[Logic Ali]

Pressing Enter in a text field causes form submission, so you must cancel submission by returning false if applicable.

The keyup event is too late to be of use:

<script type='text/javascript'>

document.onkeypress = returnKey;

function returnKey( e )
{
  var evt = e || window.event,
      node = evt.srcElement || evt.target,
      query = false;

  if ( evt.keyCode == '13' && ( query = /^(fi|kt)$/.test( node.value ) ) )
    node.value = "??";

  return !query;
}

</script>

[assaf.vilmovski]

well, thanks but that's not it

[Logic Ali]

What do you mean "that's not it"?

Are you saying I got the spec wrong or that you can't get it to work?

[assaf.vilmovski]

The code is implemented, but it's not doing what it should.

[Logic Ali]

The code is implemented, but it's not doing what it should.

That answers neither question.

Does this demo do what you expected?

[assaf.vilmovski]

It does.

I`m gonna take another look at this later.

Thank you very much for your time.

[assaf.vilmovski]

It does.
It just didn't work on the extension.
I`m gonna take another look at this later.

Thank you very much for your time.

by the way, is there a more human reabable way of writing this?
You know, to simple things out

[Logic Ali]

is there a more human reabable way of writing this?
You know, to simple things out

Simplifying it would make it more complicated, and I'm sure your teacher will understand it as it is.

[assaf.vilmovski]

well now you're insulting me...

[assaf.vilmovski]

How can I insert my code before their's?
Any ides?

[assaf.vilmovski]

One thought is using innerHTML to rewrite the targeted website's source.

[assaf.vilmovski]

now I see the real problem...
the website that the extension is working on is already using an onkeydown on the input.
So it causes their code to be executed before mine...
In all other websites it's working great.