[RESOLVED] implode array to avoid a loop

[ohnos]

$groups = $x->xpath("list/document/content[@name='group']");
$groups = array_unique($groups);

if (!empty($groups)){
echo '<ul class="groups">'.PHP_EOL;
echo '<li>'.implode('</li><li>', '<a rel="category" href="page.php?tag='.urlencode($groups).'">'.$groups.'</a></li>').PHP_EOL;
echo '</ul>';
} 

this is what I'm trying to do, any help appreciated.

[Hunter1611]

I take it your code isn't working? What exactly are you trying to do and what's it doing?

[NogDog]

Maybe something like this?

if (!empty($groups)){
    array_walk(
        $groups,
        create_function(
            '&$value, $key',
            '$value = "<li><a rel=\'category\' href=\'page.php?tag=".urlencode($value)."\'>".htmlspecialchars($value)."</a></li>";'
        )
    );
    echo '<ul class="groups">'.PHP_EOL.implode(PHP_EOL, $groups).PHP_EOL.'</ul>';
} 

[ohnos]

That's exactly what I was trying to do NogDog. I read through the array functions last night trying to figure out how to do this without looping. I'm looping to parse the rest of the page, I just needed this menu first. This is perfect. Thank you for your help.

[Derokorian]

@NogDog question: Why use create_function instead of a true lambda? Note I get the same output with your code as with the following:

if (!empty($groups)){
   array_walk(
      $groups,
      function(&$v, $k) {
         $v = "<li><a rel='category' href='page.php?tag=".urlencode($v)."'>".htmlspecialchars($v)."</a></li>";
      }
   );
   echo '<ul class="groups">'.PHP_EOL.implode(PHP_EOL, $groups).PHP_EOL.'</ul>';
} 

Just wondering if there is any reason to use one over the other? I personally like the inline lambda because then you don't have to escape the quotes in the string

[NogDog]

Because not everyone is using PHP 5.3+ yet, unfortunately.