www.webdeveloper.com
Results 1 to 3 of 3

Thread: Research about Randomising , need assistance here.

  1. #1
    Join Date
    Jan 2013
    Posts
    5

    Research about Randomising , need assistance here.

    I am currently, research the randomizing,
    and i try to make a minesweeper game to play around with my new function.
    My plan is lay ten mines inside the mine table
    but after i run my code , i got some unexpected problem which is i can't have
    ten random mines everytime i refresh it.
    I have fix some loop and code but the problem is still here.

    My current lay mines code looks like this :

    <script type="text/javascript">
    function addmines (x) {
    var n = 10; //number of mines
    var mines = []; //an empty array
    while (n>0) {
    var row = Math.floor(1+Math.random()*10);
    var col = Math.floor(1+Math.random()*10);

    if (row >= 0 && row < 10){
    if (col >= 0 && col < 10) {
    var id = "r"+ row + "c" + col;

    n++;

    var a = document.createElement("img");
    a.src = "mine32.gif";
    a.height = 30;
    a.width = 30;
    document.getElementById(id).appendChild(a);


    }
    }

    }
    return x;
    }

    </script>



    And this is my tables

    //Creates Table
    document.write('<table>');
    //for loop that creates the row, increments from 0 to 9 each time it reiterates
    for (var row=0; row<9; row++) {
    //creates the table row
    document.write('<tr>');
    //a nested for loop that reiterates 9 times creating the <td>'s and then exits to the parent for loop.
    for (var col=0; col<9; col++) {
    //references all the <td>'s with a specific id attribute.
    document.write('<td id="r', row, 'c', col, '">');
    //document.write('&nbsp;');
    //closes the <td>
    document.write('</td>');
    }
    //closes the <tr> or row in plain English
    document.write('</tr>');
    }
    //closes the <table> tag
    document.write('</table>');

    addmines();


    Can someone give me suggestion and assistance that allow me to correct my mistakes please?

  2. #2
    Join Date
    Aug 2008
    Location
    Sweden
    Posts
    227
    There are several issues. First of all, there's an error: you're trying to add an image to a <td> element that doesn't exist. So either too few <td>s are created or the numbers for your random row and column are too high or low. (Always check the console!)

    Secondly you're saying n++ instead of n-- which means that the while loop will loop forever. (n>0 will always be true.)

    Some unnecessary things that can be removed are the empty mines array and these checks:
    Code:
    if (row >= 0 && row < 10){
    if (col >= 0 && col < 10) {
    because you already know row and col will be within those boundaries when you set them. The argument variable x is also unused and can be removed.

    Here's the fixed code:
    Code:
    function addmines () {
        var n = 10; //number of mines
        while (n>0) {
            var row = Math.floor(Math.random()*9);
            var col = Math.floor(Math.random()*9);
    
            var id = "r" + row + "c" + col;
    
            var td = document.getElementById(id);
            if (td.children.length > 0)
                continue; //there's already a mine here
    
            n--;
    
            var a = document.createElement("img");
            a.src = "mine32.gif";
            a.height = 30;
            a.width = 30;
            td.appendChild(a);
    
        }
    }
    Code:
    //Creates Tabledocument.write('<table>');
    //for loop that creates the row, increments
    //from 0 to 9 each time it reiterates
    for (var row=0; row<9; row++) {
        document.write('<tr>');
        //a nested for loop that reiterates 9 times creating
        //the <td>'s and then exits to the parent for loop.
        for (var col=0; col<9; col++) {
            document.write('<td id="r', row, 'c', col, '">');
            document.write('</td>');
        }
        document.write('</tr>');
    }
    document.write('</table>');
    
    addmines();
    Last edited by ReFreezed; 01-03-2013 at 03:06 PM.

  3. #3
    Join Date
    Jan 2013
    Posts
    5
    Thank you for reply ,
    i have fixed it ,
    i had a stupid mistake ,
    everything is good now , thank you very much
    Last edited by anson920520; 01-03-2013 at 03:18 PM.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.12658 seconds
  • Memory Usage 2,858KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (3)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates