[RESOLVED] Make a div visible/hidden

[LOLMANLOL]

Why does'nt work this script?

function ChangeVis(id) {
if (document.getElementById(id).style.visibility="visible")
{
document.getElementById(id).style.visibility="hidden";
}
else if (document.getElementById(id).style.visibility="hidden")
{
document.getElementById(id).style.visibility="visible";
}
}

[bionoid]

Hi,

In your code you were doing assignments instead of comparisons. Using == or === will perform a comparison check.

function ChangeVis(id)
{
	if (document.getElementById(id).style.visibility === "visible") {
		document.getElementById(id).style.visibility = "hidden";
	} else
	if (document.getElementById(id).style.visibility === "hidden") {
		document.getElementById(id).style.visibility = "visible";
	}
}

Another way it could be done is like so:

function ChangeVis(id)
{
	var e = document.getElementById(id);
	e.style.visibility = (e.style.visibility === 'hidden') ? 'visible' : 'hidden';
}

[ReFreezed]

Using === to compare the types is not really needed here. Just use ==

[LOLMANLOL]

Thank you both for the useful advise.
You were right, I had to use == instead of =.
Really thank you.