Results 1 to 3 of 3

Thread: For Loop not working properly

  1. #1
    Join Date
    Jan 2013

    For Loop not working properly

    I am attempting to create something that will store a person's name and favorite color as cookies, and then display the person's favorite color if they have already entered it. This is the code:
    <!DOCTYPE html>
    function setCookie(Name, Color, exdays) {
    var exdate=new Date();
    exdate.setDate(exdate.getDate() + exdays);
    var c_value=escape(Color) + ((exdays==null) ? "" : ";expires=" + exdate.toUTCString());
    document.cookie=Name + "=" + c_value;//stores cookie with format "(person's name)=(person's favorite color)"
    function getCookie(user) {
    var i,x,y,ARRCookie=document.cookie.split(";");//splits at each individual cookie so they can be considered one at a time
    for (i=0;i<ARRCookie.length;i++) {
    x=ARRCookie[i].substr(0,ARRCookie[i].indexOf("="));//the name of the cookie (what comes before "=")
    y=ARRCookie[i].substr(ARRCookie[i].indexOf("=")+1);//the value of the cookie (what comes after "=")
    if (x==user) {
    return unescape(y);//if the name of the cookie matches the cookie requested, return its value
    function checkCookie() {
    var username=prompt('What is your name?','');//asks for your name to see if you have already created a cookie for yourself
    var color=getCookie(username);
    if (color!=null && color!="") {
    document.write("Your favorite color is " + color + ".");//if cookie with given name exists, state its value
    else {
    var favcolor=prompt('What is your favorite color?','');
    setCookie(username, favcolor, 365);
    <body onload="checkCookie()"></body>
    Interestingly, if, upon the prompt that asks for your name, you enter the name of the first cookie created for the page (e.g. if the first person to ever fill out set prompts to create a cookie was John and you entered John), the correct color will be returned from the function getCookie. However, if you enter the name of anyone else who has created a cookie on the page (e.g. if after John entered his data Lucy entered hers and you typed into the prompt box for your name "Lucy"), it will prompt you asking for your favorite color. When I looked in the stored cookies and site data in Chrome settings, it said that the cookies had been stored for these other names, but they still did not return the values.
    I am thinking the reason is that the "for" loop in function getCookie is not working. If x[0] (the name of the first cookie entered) has a value, great! The function returns the value of that cookie. However, if not, instead of looping back through the function (the loop), it just stops. (Again, this is just a guess.) I was thinking it had something to do with the fact that I had a "return" statement, which exits out of the loop, but it shouldn't act upon that statement unless the if condition is true (that said cookie name has a matching value--strangely, if and when it does return a value for these cookies that weren't the first ones created, it says, "Your favorite color is undefined.").
    Any help?

  2. #2
    Join Date
    Mar 2007
    It's the classic error of splitting on ";" when you need either to split on "; " or allow for the leading space when reading the names.
    Where used, return should be executed unconditionally and always as the last statement in the function.

    That's my signature, it's not part of the damn post!

  3. #3
    Join Date
    Jan 2013
    @Logic Ali Thanks! Splitting on "; " as opposed to just ";" solved all my problems. I didn't realize the document.cookie automatically added a space between the different cookies.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
HTML5 Development Center

Recent Articles