Help me with this code I cannot seem to get it to work!

**alpinefury** · 02-08-2013 10:31 AM

I need to make this function work for a school project
which requires a form to be validated. The rest of the code works but I cannot seem to get this bit to. I need to make it so when one of the radio buttons is clicked a confirmation box is brought up, with the name of the button pressed.

Eg. "You have selected ______. Are You Sure"

The blank space is where the bit needs to be.
Then when cancel is pressed the radio buttons are all unchecked.

It also must be in one function. Any help would be appreciated.

Here is what I have so far:

<html>
<head>

<script language="JavaScript">
function checkbox() {
var confirmboxyes = confirm("You've selected. Are you sure?");

if ( confirmboxyes == false){
document.getElementById("1").checked = false;
document.getElementById("2").checked = false;
document.getElementById("3").checked = false;
return true
}
else {
return false;

}
}
</script>

</head>
<body bgcolor="pink">

<form name="form">
Cats <input type="radio" name="test" value="Cats" id="1" onclick="return checkbox()"> <br>
Dogs <input type="radio" name="test" value="Dogs" id="2" onclick="return checkbox()"> <br>
Birds <input type="radio" name="test" value="Birds" id="3" onclick="return checkbox()">
</form>

</body>
</html>

**007Julien** · 02-08-2013 10:37 AM

ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons (":"), and periods (".").

**alpinefury** · 02-08-2013 11:03 AM

Ive made alterations to the code but I cannot seem to get the value of the radio buttons to be displayed in the confirm box, i was getting "invalid" for a while, but now it wont work entirely.

Heres what I have changed:

<html>
<head>

<script language="JavaScript">
function checkbox() {
var confirmboxyes = confirm("You've selected " + Selected + ". Are you sure?");
var Selected = "";
if (document.getElementsById("cats").checked == true) {Selected = document.getElementsById("cats").value;}
if (document.getElementsById("dogs").checked == true) {Selected = document.getElementsById("dogs").value);}
if (document.getElementsById("birds").checked == true) {Selected = document.getElementsById("birds").value);}

if ( confirmboxyes == false){
document.getElementById("cats").checked = false;
document.getElementById("dogs").checked = false;
document.getElementById("birds").checked = false;
return true
}
else {
return false;

}
}
</script>

</head>
<body bgcolor="pink">

<form name="form">
Cats <input type="radio" name="test" value="Cats" id="cats" onclick="return checkbox()"> <br>
Dogs <input type="radio" name="test" value="Dogs" id="dogs" onclick="return checkbox()"> <br>
Birds <input type="radio" name="test" value="Birds" id="birds" onclick="return checkbox()">
</form>

</body>
</html>

**Logic Ali** · 02-08-2013 12:02 PM

Originally Posted by alpinefury

Code:

function checkbox() {
 var confirmboxyes = confirm("You've selected " + Selected + ". Are you sure?");

At this point 'Selected' is undefined, so how can you expect to display it ?

Code:

if (document.getElementsById("cats").checked == true)    {Selected = document.getElementsById("cats").value;}

Incorrect spelling - use the error console.

Code:

if (document.getElementsById("dogs").checked == true)    {Selected = document.getElementsById("dogs").value);}
    if (document.getElementsById("birds").checked == true)    {Selected = document.getElementsById("birds").value);}

Syntax errors as shown.

You assign values to 'Selected' but the variable is not being used anywhere.

To display the button's value do this:

Code:

Cats <input type="radio" name="test" value="Cats" id="cats" onclick="return checkbox( this )">


/* then */

function checkbox( elem ) 
{
 var confirmboxyes = confirm("You've selected " + elem.value + ". Are you sure?");

**alpinefury** · 02-08-2013 12:15 PM

Slight problem again, no matter what I press on the Confirm Box ie. Confirm/Cancel all of the radio buttons are cleared how do I rectify this?

**alpinefury** · 02-08-2013 12:17 PM

And heres what I've got

<html>
<head>

<script language="JavaScript">
function checkbox(elem) {

var confirmboxyes = confirm("You've selected " + elem.value + ". Are you sure?");

if (confirmboxyes == false){
document.getElementById("cats").checked = false;
document.getElementById("dogs").checked = false;
document.getElementById("birds").checked = false;
return true
}
else {
return false;

}
}
</script>

</head>
<body bgcolor="pink">

<form name="form">
Cats <input type="radio" name="test" value="Cats" id="cats" onclick="return checkbox( this )"> <br>
Dogs <input type="radio" name="test" value="Dogs" id="dogs" onclick="return checkbox( this )"> <br>
Birds <input type="radio" name="test" value="Birds" id="birds" onclick="return checkbox( this )">
</form>

</body>
</html>

**Logic Ali** · 02-08-2013 12:20 PM

Originally Posted by alpinefury

Slight problem again, no matter what I press on the Confirm Box ie. Confirm/Cancel all of the radio buttons are cleared how do I rectify this?

Show the entire code in its current state, this time within [ code][/code] tags (press # button).

**Logic Ali** · 02-08-2013 12:36 PM

Originally Posted by alpinefury

Slight problem again, no matter what I press on the Confirm Box ie. Confirm/Cancel all of the radio buttons are cleared how do I rectify this?

If you return false, the clicked button is cleared even if you don't clear it.

**alpinefury** · 02-08-2013 01:00 PM

so how do i make it so it works? sorry about the silly question new to JavaScript

**alpinefury** · 02-08-2013 03:05 PM

I've sorted it out now, thanks for the help!

Thread: Help me with this code I cannot seem to get it to work!

Thread Tools

Display

Help me with this code I cannot seem to get it to work!

Thread Information

Users Browsing this Thread

Tags for this Thread

Bookmarks

Bookmarks

Posting Permissions