[RESOLVED] Warning: Wrong parameter count for in_array() in...

[Alan P]

I'm getting this error on my page counter: Warning: Wrong parameter count for in_array() in... on line 14.

Here's the code:

$user_agents = getenv('HTTP_USER_AGENT');
$losers = array(
'Mozilla/5.0 (compatible; Baiduspider/2.0; +http://www.baidu.com/search/spider.html)',
'Mozilla/5.0 (compatible; bingbot/2.0; +http://www.bing.com/bingbot.htm)',
'Mozilla/5.0 (compatible; AhrefsBot/4.0; +http://ahrefs.com/robot/)',
'Mozilla/5.0 (compatible; YandexBot/3.0; +http://yandex.com/bots)',
'Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)',
'Wotbox/2.01 (+http://www.wotbox.com/bot/)',
'TurnitinBot/2.1 (http://www.turnitin.com/robot/crawlerinfo.html)',
'Mozilla/5.0 (compatible; Ezooms/1.0; ezooms.bot@gmail.com)'
);

if (!in_array($user_agents))
{
    session_start();
    // global $counter;

    mysql_connect($host,$username,$password);
    @mysql_select_db($database) or die( "Unable to select database");

    if (!isset($_SESSION['countme']))
    {
        $_SESSION['countme']="set";
        $sql="SELECT * FROM count";
        $result = mysql_query($sql);
        $row = mysql_fetch_assoc($result);
        $count = $row['value'];

        $newcount = $count + 1;

        $sql="UPDATE count SET value='$newcount'";
        $result = mysql_query($sql);
    }
} 

This is line 14:

if (!in_array($user_agents)) 

I don't think the counter is working right either. Any help will be appreciated.

[NogDog]

See www.php.net/in_array in the user manual, and notice that it has 2 required parameters and a 3rd optional parameter.

However, at this point I'm not sure what array you would be wanting to check at that point, anyway?

[Alan P]

if (!in_array($user_agents, $losers, true)) 

The website owner wanted a visitor counter, but I didn't want some robots counted so I wanted to check the HTTP_USER_AGENT of those accessing the website to see if they were in the array and if so they would not be added to the visitor count.

I appreciate the link.

[NogDog]

So you just want to add $losers as the 2nd parameter, right?

[Alan P]

Yes, I believe the page you linked to said that the second parameter was the array to be searched, which would be $losers.

I used "if (!in_array($user_agents, $losers, true))" which I took to mean - "if not in array" or if this HTTP_USER_AGENT is not listed in this array ($losers).

[NogDog]

Sounds right, to me. If you have the User Agent Switcher add-on in Firefox, it should be pretty easy to test and make sure.

[Alan P]

I'll look into it. Thanks for the tip and the help.