www.webdeveloper.com
Results 1 to 3 of 3

Thread: Need help with insert form

  1. #1
    Join Date
    Jun 2008
    Posts
    39

    Need help with insert form

    Hi,

    I have the insert form below which works just fine except for the if else condition.
    If the name already exists, i'd like it to echo name already exists.
    I know that I am doing something wrong. Can someone help?
    Thanks much !


    PHP Code:


    if(isset($_REQUEST['add_group']))
    {



    $result_content = mysql_query ("SELECT * FROM $table_group WHERE first_name = '" . $first_name. "' limit 1 ");

    if ( mysql_num_rows($result_content)==0){

    $sql="INSERT INTO $table_group (first_name, last_name)VALUES('$first_name', '$last_name')"; }else { echo  "Name already exists"; }

    $result=mysql_query($sql);

    // if successfully insert data into database, displays message "Successful".
    if($result){
    echo "Successful";
    echo "<BR>";
    echo "<a href='insert.php'>Back to main page</a>";
    }

    else {
    echo "ERROR";
    }
    }
    // close connection
    mysql_close();


    ?>

    <table width="300" border="0" align="center" cellpadding="0" cellspacing="1">
    <tr>
    <td><form name="form1" method="post" action="insertTest.php">
      
    <?php

        
    if (isset($data_content["first_name"]) and
                
    $data_content["first_name"] != '' and
                !isset(
    $_POST['first_name'])) {
            
    $first_name $data_content["first_name"];
        } elseif (isset(
    $_POST['first_name'])) {
            
    $first_name $_POST['first_name'];
        } else {
            
    $first_name '';
        } 
        
    $first_name htmlentities(stripslashes($first_name), ENT_QUOTES$character_set);

        if (isset(
    $data_content["last_name"]) and
                
    $data_content["last_name"] != '' and
                !isset(
    $_POST['last_name'])) {
            
    $last_name $data_content["last_name"];
        } elseif (isset(
    $_POST['last_name'])) {
            
    $last_name $_POST['last_name'];
        } else {
            
    $last_name '';
        } 
        
    $last_name htmlentities(stripslashes($last_name), ENT_QUOTES$character_set);
    ?>

    <table width="100%" border="0" cellspacing="1" cellpadding="3">
    <tr>
    <td colspan="3"><strong>Insert Data Into mySQL Database </strong></td>
    </tr>
    <tr>
    <td width="71">First name</td>
    <td width="6">:</td>
    <td width="301"><input name="first_name" type="text" id="first_name" value="<?php echo $first_name ?>"></td>
    </tr>
    <tr>
    <td>Lastname</td>
    <td>:</td>
    <td><input name="last_name" type="text" id="last_name" value="<?php echo $last_name ?>"></td>
    </tr>

    <tr>
    <td colspan="3" align="center"><input type="submit" name="add_group" value="Submit"></td>
    </tr>
    </table>
    </form>
    </td>
    </tr>
    </table>
    Last edited by fagin; 02-22-2013 at 02:51 PM.

  2. #2
    Join Date
    Nov 2012
    Location
    Jakarta
    Posts
    42
    I am not sure what the problem here. But, looking at the code, check this lines:
    Code:
    if ( mysql_num_rows($result_content)==0){
    
    $sql="INSERT INTO $table_group (first_name, last_name)VALUES('$first_name', '$last_name')"; }else { echo  "Name already exists"; }
    
    $result=mysql_query($sql);
    the line:
    Code:
    $result=mysql_query($sql);
    is outside the "if then else" loops which means, the query is always executed.

    This is a problem if name already exists, because the string $sql is empty.

    So, try moving the code inside the if then loop.

    Good luck!

  3. #3
    Join Date
    Jun 2008
    Posts
    39

    Solved

    thanks for your response. talking about putting it in the loop got me to thinking...and here is the code that works.

    I added these also:
    $first_name = $_POST['first_name'];
    $last_name = $_POST['last_name'];


    PHP Code:
      if(isset($_REQUEST['add_group'])) {

     // Get values from form
        $first_name = $_POST['first_name'];
        $last_name = $_POST['last_name']; 

    $result_content = mysql_query ("SELECT * FROM $table_group WHERE first_name = '" . $first_name. "' limit 1 ");

         if ( mysql_num_rows($result_content) == 0) {
          $sql = "INSERT INTO $table_group (first_name, last_name) VALUES ('$first_name', '$last_name')";
        } else {
          echo "Name already exists";
        }
        $result = mysql_query($sql);
        // if successfully insert data into database, displays message "Successful".
        if($result) {
          echo "Successful<br />\n
          <a href='insert.php'>Back to main page</a>";
        } else {
          echo "ERROR";
        }
      }
      // close connection
      mysql_close();
    ?>
    <table width="300" border="0" align="center" cellpadding="0" cellspacing="1">
      <tr>
        <td>
          <form name="form1" method="post" action="test.php">
            <?php
              
    if(isset($data_content["first_name"]) && $data_content["first_name"] != '' && !isset($_POST['first_name'])) {
                
    $first_name $data_content["first_name"];
              } elseif(isset(
    $_POST['first_name'])) {
                
    $first_name $_POST['first_name'];
              } else {
                
    $first_name '';
              }
              
    $first_name htmlentities(stripslashes($first_name), ENT_QUOTES$character_set);
              if(isset(
    $data_content["last_name"]) && $data_content["last_name"] != '' && !isset($_POST['last_name'])) {
                
    $last_name $data_content["last_name"];
              } elseif(isset(
    $_POST['last_name'])) {
                
    $last_name $_POST['last_name'];
              } else {
                
    $last_name '';
              }
              
    $last_name htmlentities(stripslashes($last_name), ENT_QUOTES$character_set);
            
    ?>
            <table width="100%" border="0" cellspacing="1" cellpadding="3">
              <tr>
                <td colspan="3">
                  <strong>Insert Data Into mySQL Database </strong>
                </td>
              </tr>
              <tr>
                <td width="71">First name</td>
                <td width="6">:</td>
                <td width="301"><input name="first_name" type="text" id="first_name" value="<?php echo $first_name ?>"></td>
              </tr>
              <tr>
                <td>Lastname</td>
                <td>:</td>
                <td><input name="last_name" type="text" id="last_name" value="<?php echo $last_name ?>"></td>
              </tr>
              <tr>
                <td colspan="3" align="center"><input type="submit" name="add_group" value="Submit"></td>
              </tr>
            </table>
          </form>
        </td>
      </tr>
    </table>

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.13546 seconds
  • Memory Usage 2,912KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (2)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates