www.webdeveloper.com
Results 1 to 3 of 3

Thread: unable to edit row in the table

  1. #1
    Join Date
    Mar 2013
    Posts
    1

    Question unable to edit row in the table

    <?php

    $con=mysqli_connect("localhost","root","","test");
    if (mysqli_connect_errno($con))
    {
    echo "Failed to connect to MySQL: " . mysqli_connect_error();
    }

    ?>
    <?php

    $strSQL = "UPDATE student SET ".$_POST[rollno]."' ";
    $strSQL .=",name = '".$_POST["name"]."' ";
    $strSQL .=",phone = '".$_POST[phone]."' ";
    $strSQL .=",address = '".$_POST["address"]."' ";
    $strSQL .=",salary = '".$_POST[salary]."' ";
    $strSQL .="WHERE rollno = '".$_POST[rollno]."' ";
    $query = mysql_query($strSQL);

    $result = mysqli_query($query,$con);

    echo "<table border='3' bgcolor='#FFFF00'>
    <tr>
    <th>Roll</th>
    <th>Name</th>
    <th>Phone</th>
    <th>Address</th>
    <th>Salary</th>
    </tr>";

    while($row = mysqli_fetch_array($result))
    {
    echo "<tr>";
    echo "<td>" . $row[rollno] . "</td>";
    echo "<td>" . $row['name'] . "</td>";
    echo "<td>" . $row[phone] . "</td>";
    echo "<td>" . $row['address'] . "</td>";
    echo "<td>" . $row[salary] . "</td>";
    echo "<td colspan='6' align='center'><a href=update.php?id=".$row[rollno].">Update</td>";
    echo "</tr>";
    }

    echo "</table>";
    ?>

  2. #2
    Join Date
    Mar 2013
    Location
    Iasi, Romania
    Posts
    53
    you should use $row['field_name']...always put the field name inside ' '

  3. #3
    Join Date
    Jun 2011
    Posts
    10
    Quote Originally Posted by ssdog View Post
    you should use $row['field_name']...always put the field name inside ' '
    ... unless you're inside of a double-quote delimited string, in which case you would not want to add the quotes around the index value. (There aren't any instances of this in the OP's code - just mentioning it as an option to shorten the code a bit.)

    @subrat: You've got one instance of a mysql_*() function in the code you posted above; if you're using MySQLi, then you can't use any of those functions. Furthermore, you subsequently try to call mysqli_query() but give it the wrong variable name ($query is an undefined variable).

    Note that user-supplied data should never be placed directly into a SQL query string, else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, you must first sanitize the data (e.g. using mysqli_real_escape_string() for string data) or use prepared statements.

    Finally, note that you never check to see if your SQL query was executed successfully and, if not, logging the SQL-provided error message (and hopefully notifying the end user that something went wrong).

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.15919 seconds
  • Memory Usage 2,860KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates