www.webdeveloper.com
Results 1 to 3 of 3

Thread: Porting getAttributeNode to getAttribute

  1. #1
    Join Date
    Apr 2013
    Posts
    2

    Porting getAttributeNode to getAttribute

    Hello,

    i am very new to javascript and need some help to get rid of some deprecated warnings coming from an old jquery release. I cannot update to a newer version yet so i need get rid of these warnings. Newer browsers throw out a warning not to use "getAttributeNode" and "nodeValue" anymore. It is recommended to use "getAttribute" and also "value" instead...

    I already tried myself but something is just not working. Maybe someone can help me? I would be so happy

    The first part is here

    Code:
    jQuery.each( text || this, function(){
    	jQuery.each( this.childNodes, function(){
    		if ( this.nodeType != 8 )
    			ret += this.nodeType != 1 ?
    				this.nodeValue :
    				jQuery.fn.text( [ this ] );
    	});
    });
    can i just replace with this.value ?

    Here are the other two function i am not sure how to rewrite them correctly

    Code:
    // browsers index elements by id/name on forms, give priority to attributes.
    if( jQuery.nodeName( elem, "form" ) && elem.getAttributeNode(name) )
    	return elem.getAttributeNode( name ).nodeValue;
    
    // elem.tabIndex doesn't always return the correct value when it hasn't been explicitly set
    // http://fluidproject.org/blog/2008/01/09/getting-setting-and-removing-tabindex-values-with-javascript/
    if ( name == "tabIndex" ) {
    	var attributeNode = elem.getAttributeNode( "tabIndex" );
    	return attributeNode && attributeNode.specified
    		? attributeNode.value
    		: elem.nodeName.match(/(button|input|object|select|textarea)/i)
    			? 0
    			: elem.nodeName.match(/^(a|area)$/i) && elem.href
    				? 0
    				: undefined;
    }
    Code:
    if ( !!document.getElementById( id ) ) {
    	Expr.find.ID = function(match, context, isXML){
    		if ( typeof context.getElementById !== "undefined" && !isXML ) {
    			var m = context.getElementById(match[1]);
    			return m ? m.id === match[1] || typeof m.getAttributeNode !== "undefined" && m.getAttributeNode("id").nodeValue === match[1] ? [m] : undefined : [];
    		}
    	};
    
    	Expr.filter.ID = function(elem, match){
    		var node = typeof elem.getAttributeNode !== "undefined" && elem.getAttributeNode("id");
    		return elem.nodeType === 1 && node && node.nodeValue === match;
    	};
    }

  2. #2
    Join Date
    Jul 2008
    Location
    urbana, il
    Posts
    2,787
    Code:
    return elem.getAttributeNode( name ).nodeValue;
    is now
    Code:
    return elem.getAttribute( name )

    return m ? m.id === match[1] || typeof m.getAttributeNode !== "undefined" && m.getAttributeNode("id").nodeValue === match[1] ? [m] : undefined : [];[/code]

    can be (i think)
    Code:
    o = m ?   (m.id === match[1] || m.id === match[1] ? [m] : undefined ) : [];
    Code:
    Expr.filter.ID = function(elem, match){
    		var node = typeof elem.getAttributeNode !== "undefined" && elem.getAttributeNode("id");
    		return elem.nodeType === 1 && node && node.nodeValue === match;
    	};
    could be
    Code:
    Expr.filter.ID = function(elem, match){
    		return elem.id;
    	};
    the other parts have so much to do with just reading attrib nodes i don't see how/why they should be converted; we should just fix the upstream calls so they are never used.

    i know this isn't perfect, but i hope this gets you closer.
    Create, Share, and Debug HTML pages and snippets with a cool new web app I helped create: pagedemos.com

  3. #3
    Join Date
    Apr 2013
    Posts
    2
    Many many thanks

    i will try your suggestions soon. As long as these warnings disappear i can sleep good again

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.16279 seconds
  • Memory Usage 2,852KB
  • Queries Executed 13 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (8)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates