www.webdeveloper.com
Results 1 to 6 of 6

Thread: [RESOLVED] Separating JS from HTML

Hybrid View

  1. #1
    Join Date
    Dec 2005
    Location
    TX
    Posts
    7,931

    resolved [RESOLVED] Separating JS from HTML

    I'm trying to separate the HTML from the JS function, but having not much luck.
    Any ideas why I can not accomplish this?
    Code:
    <!DOCTYPE HTML>
    <html>
    <head>
    <title> FAQ  display</title>
    <meta charset="utf-8">
    
    <style type="text/css">
     dt { line-height: 1.5em; }
    </style>
     
    </head>
    <body>
    
    <h1> FAQ List </h1>
    
     <dl id="FAQlist">
      <dt>faq #1</dt>
      <dd>Answer to FAQ #1</dd>
       <dt>faq #2</dt>
      <dd>Answer to FAQ #2</dd>
      <dt>faq #3</dt>
      <dd>Answer to FAQ #3</dd>
      <dt>More faqs </dt>
      <dd>Answers to additional FAQs</dd>
      <!-- other Questions and Answers follow -->
     </dl>
    
    <script type="text/javascript">
    function toggleDD(IDS) {
      var tmp = document.getElementById(IDS);   
      if (tmp.style.display != 'block') { tmp.style.display = 'block'; }
                                   else { tmp.style.display = 'none'; }
    }
    window.onload = function() {
    // set-up actions of DL, DT and DD display
      var sel = document.getElementById('FAQlist').getElementsByTagName('dt');
      for (var i=0; i<sel.length; i++) {
        sel[i].onclick="toggleDD('faq"+i+"')";
        sel[i].style.cursor= 'pointer';
      }
     
      sel = document.getElementById('FAQlist').getElementsByTagName('dd');
      for (var i=0; i<sel.length; i++) {
        sel[i].id = 'faq'+i;
        sel[i].style.display = 'none';
      }
    // dd and dt must match in pairings of dl list
    }
    </script>
    </body>
    </html>
    I'm not getting any errors, but then it doesn't do what I expect anyway ???
    Expect to toggle display for FAQ answers based upon users click.
    Last edited by JMRKER; 05-06-2013 at 11:14 AM.

  2. #2
    Join Date
    May 2006
    Location
    Somewhere behind your screen
    Posts
    1,716
    put the script in the head section like all the good boyz do and change it a little:

    Code:
    </style>
     <script type="text/javascript">
    function toggleDD(IDS) {
      var tmp = document.getElementById(IDS);
      if (tmp.style.display != 'block') { tmp.style.display = 'block'; }
                                   else { tmp.style.display = 'none'; }
    }
    window.onload = function() {
    // set-up actions of DL, DT and DD display
      var sel = document.getElementById('FAQlist').getElementsByTagName('dt');
      for (var i=0; i<sel.length; i++){ 
      sel[i].id='dt'+i;
      sel[i].onclick=function(){toggleDD('faq'+this.id.substring(2,this.id.length));}
      }
     
      sel = document.getElementById('FAQlist').getElementsByTagName('dd');
      for (var i=0; i<sel.length; i++) {
        sel[i].id='faq'+i;
        sel[i].style.display = 'none';
        sel[i].style.cursor= 'pointer';
      }
    // dd and dt must match in pairings of dl list
    }
    </script>
    </head>
    Last edited by Padonak; 05-06-2013 at 11:38 AM. Reason: fkn 3G modem missed data
    signature under construction

  3. #3
    Join Date
    Dec 2005
    Location
    TX
    Posts
    7,931

    Thumbs up

    Quote Originally Posted by Padonak View Post
    put the script in the head section
    That did nothing. Same results.

    I experimented some more and came up with this solution. Just alter the SCRIPT section to...
    Code:
    <script type="text/javascript">
    function toggleDD(IDS) {
      var tmp = document.getElementById(IDS);   
      if (tmp.style.display != 'block') { tmp.style.display = 'block'; }
                                   else { tmp.style.display = 'none'; }
    }
    window.onload = function() {
    // set-up actions of DL, DT and DD display
      var sel = document.getElementById('FAQlist').getElementsByTagName('dt');
      for (var i=0; i<sel.length; i++) {
        sel[i].id= 'faq'+i;
        sel[i].onclick= function () { toggleDD('_'+this.id); } 
        sel[i].style.cursor= 'pointer';
      }
     
      sel = document.getElementById('FAQlist').getElementsByTagName('dd');
      for (var i=0; i<sel.length; i++) {
        sel[i].id = '_faq'+i;
        sel[i].style.display = 'none';
      }
    // dd and dt must match in pairings of dl display
    }
    </script>
    All else is the same with script just before the </body> tag.

  4. #4
    Join Date
    May 2006
    Location
    Somewhere behind your screen
    Posts
    1,716
    read again my prev post pls
    signature under construction

  5. #5
    Join Date
    Dec 2005
    Location
    TX
    Posts
    7,931
    Quote Originally Posted by Padonak View Post
    read again my prev post pls
    Thanks, that worked too.

    I did not see your code in your posting #2 (perhaps you added it after my post #3 ???)
    or I must have done something wrong when I copied/pasted from my original post.

    Either way, now I have two versions that do the same thing.

  6. #6
    Join Date
    May 2006
    Location
    Somewhere behind your screen
    Posts
    1,716
    i have internet access through a 3G modem and sometimes some parts of my posts get lost. i noticed that the post #2 is incorrect and reposted the full version
    signature under construction

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.32882 seconds
  • Memory Usage 3,059KB
  • Queries Executed 13 (?)
More Information
Template Usage (31):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (3)bbcode_code
  • (2)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (6)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (6)postbit
  • (6)postbit_onlinestatus
  • (6)postbit_wrapper
  • (1)showthread_list
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (27):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./includes/functions_threadedmode.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids_threaded
  • showthread_threaded_construct_link
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates