www.webdeveloper.com
Results 1 to 2 of 2

Thread: I dont understand whats going on with this variable.

  1. #1
    Join Date
    Feb 2013
    Posts
    19

    I dont understand whats going on with this variable.

    The name variable in my text game acts funny.When I run the stats or help functions which are triggered by typing in those words, it changes the name variable to either stats or help. Why?
    Here is the game:

    //mycode

    <html>

    <head>
    <title> Game of Thrones the Text Game </title>


    <head>

    <body>
    <header>

    <script src = "http://ajax.googleapis.com/ajax/libs/jquery/1.6.3/jquery.min.js"> </script>

    <script>

    var name = "";
    var strength = 1;
    var agility = 1;
    var lifepoints = 10;
    var armorrating = 0;
    var weaponrating = 0;


    $(document).ready(function() {

    function CheckForCommand(choice, go) {
    if (choice.toUpperCase() === "help".toUpperCase()) {
    Help(go);
    };

    if (choice.toUpperCase() === "stats".toUpperCase()) {
    CheckStats(go);

    };



    };


    function CheckStats(go) {
    $("header").append("<p>-= Stats =-");
    $("header").append("<p>Strength " + strength + "</p>");
    $("header").append("<p>Agility " + agility + "</p>");
    $("header").append("<p>Life Points " + lifepoints + "</p>");
    $("header").append("<p>Armor Rating " + armorrating + "</p>");
    $("header").append("<p>Weapon Rating " + weaponrating + "</p>");

    $("#button").click(function(){
    $("p").hide();
    go();
    });

    };

    function Help(go) {
    $("header").append("<p>-= Help =-<p>");
    $("header").append("<p>The TALK command can be used to talk to a quest npc if one is present. Quest NPCs appear in certain places depending on your level. Completing quests will earn you rewards.</p>");
    $("header").append("<p>The ATTACK command can be used to attack a Quest NPC if is part of a quest.</p>");
    $("header").append("<p>The STATS command can be used to check you stats such as armor rating and strength. As your level increases your stats will increase.</p>");
    $("header").append("<p>The EQUIP command can be used to equip different items.</p>");


    $("#button").click(function(){
    $("p").hide();
    go();
    });
    };

    function KingsLanding() {
    $("header").append("<p>-= King's Landing =-</p>");
    $("header").append("<p>1. Enter Weapon Smith</p>");
    $("header").append("<p>2. Enter Kings Landing Armory</p>");
    $("header").append("<p>3. Enter Kings Landing College of Proffesions</p>");
    $("header").append("<p>4. Enter Black Pony Bar</p>");
    $("header").append("<p>5. Enter Provision Store</p>");
    $("header").append("<p>6. Leave Kings Landing</p>");
    $("header").append("<p>" + name + ", Enter a number. Type help for more information.</p>");


    $("#button").click(function(){

    $("p").hide();
    var choice = $("#text").val();
    CheckForCommand(choice, KingsLanding);
    });


    };

    function choosename() {

    $("header").append("<p>Please enter your characters name.</p>");

    $("#button").click(function(){
    $("p").hide();
    name = $("#text").val();
    KingsLanding();
    });
    };




    choosename();

    });

    </script>

    </header>

    <body>

    <input type="text" id="text">
    <p></p>
    <input type="button" value="ok" id = "button">

    </body>

    </html>

  2. #2
    Join Date
    Oct 2007
    Location
    Western Massachusetts, USA
    Posts
    387
    You overlooked the fact that you have two separate if statements - combine them with an else statement:
    This:
    Code:
    function CheckForCommand(choice, go) {
      if (choice.toUpperCase() === "help".toUpperCase()) {
      Help(go);
      };
      if (choice.toUpperCase() === "stats".toUpperCase()) {
      CheckStats(go);
      };
    };
    Could be:
    Code:
    function CheckForCommand(choice, go) {
      if (choice.toUpperCase() === "help".toUpperCase()) {
      Help(go);
      }
      else if (choice.toUpperCase() === "stats".toUpperCase()) {
      CheckStats(go);
      }
    }
    Should be:
    Code:
    function CheckForCommand(choice, go) {
      switch (choice.toUpperCase()) {
      case "HELP": Help(go); break;
      case "STATS": CheckStats(go); break;
      }
    }
    Note that scopes don't need trailing semicolons unless they are part of statements. E.g. "var something = function(){};" should be done while "function(){};" should not.
    Last edited by savvykms; 07-03-2013 at 05:30 PM.
    Computer programmer / web developer.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.15240 seconds
  • Memory Usage 2,853KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (3)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (2)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates