www.webdeveloper.com
Results 1 to 2 of 2

Thread: Account Creation

Hybrid View

  1. #1
    Join Date
    Jul 2013
    Posts
    1

    Account Creation

    I am having a bit of trouble getting this register function to work. Its for a game server so the password has to be md5 and salted with the username. Here is the function part of the Register.
    This is using MVC by the way.
    Code:
    <?php
    
    class Register extends MainController{
    	function __construct(){
    						debug_backtrace();
    			parent::__construct();
    			$this->view->url	=	$this->config->url;
    			$this->view->ID 	  = get_class($this);
    			$this->view->Title = "Royal JD > Create Account";
    			$this->view->render('Register');
    
    	function Create_Account(){
    		$username = isset($_POST['username']) ? $_POST['username'] : '';
    		$email = isset($_POST['email']) ? $_POST['email'] : '';
    		$password = isset($_POST['password']) ? $_POST['password'] : '';
    		$username = mysql_real_escape_string(StrToLower(Trim($username)));
    		$password = mysql_real_escape_string(StrToLower(Trim($password)));
    
    		$this->view->salt = $username;
    		$this->view->salt = $username.$password;
    		$this->view->salt = md5($this->view->salt);
    		$this->view->salt = "0x".$this->view->salt; //Salts the password in md5.
    		
    			$sql = "INSERT INTO users WHERE name = :name AND passwd = :passwd AND idnumber = :idnumber AND email = :email";
    			$arr = array(":name" => $username, ":email" => $email, ":idnumber" => $password, ":passwd" => $this->view->salt);
    			$ctr = $this->database->DBQry($sql,$arr);
    		}
    	
    }
    }
    ?>
    the database.php looks like this:

    Code:
    <?php
    
    
    	class Database extends PDO{
    		
    		// Initialize
    		const DBHOST  = "localhost";
    		const DBNAME  = "test";
    		const DBUSER  = "root";
    		const DBPASS  = "123";
    		
    		const SELECT  = "SELECT * FROM ";
    		const INSERT  = "INSERT INTO ";
    		const UPDATE  = "UPDATE ";
    		const DELETE  = "DELETE FROM ";
    		
    		
    		// Make Connection
    		function __construct(){
    			parent::__construct("mysql:host=".self::DBHOST.";dbname=".self::DBNAME,self::DBUSER,self::DBPASS);
    		}
    		
    		// Query
    		function DBQry($sql,$arr){
    			$sth = $this->prepare($sql, array(PDO::ATTR_CURSOR => PDO::CURSOR_FWDONLY));
    			$sth->execute($arr);
    			$rs = $sth->fetchAll();
    			return $rs;
    		}
    		
    		// Count
    		function DBCtr($sql,$arr){
    			$sth = self::prepare($sql, array(PDO::ATTR_CURSOR => PDO::CURSOR_FWDONLY));
    			$sth->execute($arr);
    			return $sth->rowCount();
    		}
    		
    		// Last ID
    		function DBLst($table){
    			$sql = $this->SELECT.$table." ORDER BY id DESC LIMIT 1";
    			$arr = array();
    			$ctr = self::DBCtr($sql,$arr);
    			$rs =  self::DBQry($sql,$arr);
    			return ($ctr > 0) ? $rs[0]['id'] : 0;
    		}
    		
    		// Insert
    		function DBIns($arr,$tbl){
    			$fld = 	implode(",",array_keys($arr));
    			$sql =  self::INSERT.$tbl." (".str_replace(":","",$fld).")
    					 VALUES(".$fld.")";
    					 
    			$sth = $this->prepare($sql, array(PDO::ATTR_CURSOR => PDO::CURSOR_FWDONLY));
    			$sth->execute($arr);
    		}
    		
    		// Update
    		function DBSet($arr,$tbl,$whr = ''){
    			$stmt = array();
    			foreach($arr as $fld => $val){
    				$stmt[] =  str_replace(":","",$fld)." = ".$fld;
    			}
    			$stm =  implode(",",$stmt);
    			$sql =  self::UPDATE.$tbl." SET ".$stm.' '.$whr;
    			$sth =  $this->prepare($sql, array(PDO::ATTR_CURSOR => PDO::CURSOR_FWDONLY));
    			$sth->execute($arr);
    		}
    		
    		// Delete
    		function DBDel($tbl,$whr = ''){
    			$sql = self::DELETE.$tbl." ".$whr;
    			$this->exec($sql);
    		}
    		
    		
    	
    		
    	}
    
    
    
    ?>
    My issue is that its not sending any info to the database.

    Any help will be appreciated!

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    Nothing immediately jumps out at me as wrong, so I'd recommend adding some checking of return values and error_log()-ing (or just die()-ing for now?)
    PHP Code:
            function DBQry($sql,$arr){
                
    $sth $this->prepare($sql, array(PDO::ATTR_CURSOR => PDO::CURSOR_FWDONLY));
                if(
    $sth == false) {
                    
    $msg $this->errorInfo();
                    
    error_log("Prepare failed".PHP_EOL.print_r($msgtrue).PHP_EOL.$sql); // die() instead if you just want simple debugging for now
                    
    return false;
                }
                if(
    $sth->execute($arr) == false) {
                    
    $msg =$sth->errorInfo();
                    
    error_log("Execute failed".PHP_EOL.print_r($msgtrue).PHP_EOL.$sql);
                    return 
    false;
                }
                
    $rs $sth->fetchAll();
                return 
    $rs;
            } 
    (You could move some of the error logging/output stuff into a separate method and just call it with the desired parameters in order to clean it up and avoiding repetitious code.)
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.11752 seconds
  • Memory Usage 2,926KB
  • Queries Executed 13 (?)
More Information
Template Usage (31):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (2)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)showthread_list
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (27):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./includes/functions_threadedmode.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids_threaded
  • showthread_threaded_construct_link
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates