www.webdeveloper.com
Results 1 to 4 of 4

Thread: I need help doing making images change

  1. #1
    Join Date
    Aug 2013
    Posts
    2

    I need help doing making images change

    What is wrong with this code:
    Code:
    var i = 0;
    
    function time() {
    	window.setInterval(change(), 5000);
    }
    
    function change() {
    	i++;
    	if (i = 1) {
    		document.getElementById("slider").src="img/index/Image1.jpg";
    	}
    	else if (i = 2) {
    		document.getElementById("slider").src="img/index/Image2.jpg";
    	}
    	else if (i = 3) {
    		document.getElementById("slider").src="img/index/Image3.jpg";
    	}
    	else if (i = 4) {
    		document.getElementById("slider").src="img/index/Image4.jpg";
    	}
    	else if (i = 5) {
    		document.getElementById("slider").src="img/index/Image5.jpg";
    	}
    	else if (i = 6) {
    		document.getElementById("slider").src="img/index/Image6.jpg";
    	}
    	else if (i = 7) {
    		document.getElementById("slider").src="img/index/Image7.jpg";
    	}
    	else if (i = 8) {
    		document.getElementById("slider").src="img/index/Image8.jpg";
    	}
    	else if (i = 9) {
    		document.getElementById("slider").src="img/index/Image9.jpg";
    	}
    }
    I need some images to change every 5 seconds. I called "time()" when the body tag loads.

  2. #2
    Join Date
    Aug 2013
    Posts
    2

    resolved Solved

    I changed my code to:
    Code:
    var i = 0;
    var images = [];
    images [0] = "img/index/Image1.jpg";
    images [1] = "img/index/Image2.jpg";
    images [2] = "img/index/Image3.jpg";
    images [3] = "img/index/Image4.jpg";
    images [4] = "img/index/Image5.jpg";
    images [5] = "img/index/Image6.jpg";
    images [6] = "img/index/Image7.jpg";
    images [7] = "img/index/Image8.jpg";
    images [8] = "img/index/Image9.jpg";
    
    function time() {
    	 var timer = setInterval(change, 2500);
    }
    
    function change() {
    	document.getElementById("slider").src = images[i];
    	i++;
    	if (i >= images.length) {
    		i = 0;
    	}
    }
    And it Worked!!

  3. #3
    Join Date
    Jun 2008
    Posts
    106
    Nice.

    I don't want to confuse you, but if you have the images named like that, you could get rid of that array.

    Code:
    var i = 1, slider;
    
    function time() {
        slider = document.getElementById('slider');
        setInterval(change, 2500);
    }
    
    function change() {
        slider.src = 'img/index/Image' + i + '.jpg';
        i = i >= 9 ? 1 : i + 1; // may be confusing
    }

  4. #4
    Join Date
    Feb 2014
    Posts
    1
    Hi everyone,

    Could someone help me out on this one? The story is, I have got a fixed html code which I can not change. There is a div contaning a picture, I need to change that picture to show five other pictures randomly using getElementById.
    I have got some js coding already, but couldnt manage to change that div. My ideas were like creating a new function {window.onLoad getElementById then document.write and the rest od the code for the random pics, but it wasnt working. Tried to create a new var for the Math.floor(Math.random... and then combine this together in different ways.. Nothing. I am new to JS(only 2months) anyone could help me out on this one?

    Thanks

    Here is the JS code I have ps that commented document.write line is working but instead of displaying it on the top, it should be in a specific div.
    Code:
    var delay=1000; //set delay in miliseconds
    var curindex=0;
    
    var randomimages=new Array();
    
    	randomimages[0]="images/img06.jpg";
    	randomimages[1]="images/img07.jpg";
    	randomimages[2]="images/img08.jpg";
    	randomimages[3]="images/img09.jpg";
    	randomimages[4]="images/img10.jpg";	
    var preload=new Array();
    
    for (n=0;n<randomimages.length;n++)
    {
    	preload[n]=new Image();
    	preload[n].src=randomimages[n];
    }
    function changediv ()
    {
    	document.getElementById('splash').innerHTML=document.write('<img name="splash" src="'+randomimages[Math.floor(Math.random()*(randomimages.length))]+'">');
    	}
    	
    // window.onload=changediv();
    // window.onload=getElementById('splash'){document.write(randomimages[Math.floor(Math.random()*(randomimages.length)))};
    // document.write('<img name="splash" src="'+randomimages[Math.floor(Math.random()*(randomimages.length))]+'">');
    
    function rotateimage()
    {
    
    if (curindex==(tempindex=Math.floor(Math.random()*(randomimages.length)))){
    curindex=curindex==0? 1 : curindex-1;
    }
    else
    curindex=tempindex;
    
    	document.images.splash.src=randomimages[curindex];
    }
    
    setInterval("rotateimage()",delay);
    Last edited by jedaisoul; 03-20-2014 at 03:50 PM. Reason: code tags added

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.26385 seconds
  • Memory Usage 2,872KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (4)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (4)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates