www.webdeveloper.com
Results 1 to 6 of 6

Thread: Change Image every 4 seconds in Javascript

  1. #1
    Join Date
    Feb 2006
    Posts
    3

    Change Image every 4 seconds in Javascript

    Hello all,

    The code below supposed to change the displayed picture from pic1 to pic2 in 4 seconds after pressing the 1st picture, when i execute it after 4 seconds there is an error saying "Pic is Undefined", please help me find the problem?
    Thanx.

    Code:
    <head>
        <script type="text/javascript">
            function TimerSwitch(pic) {
                TimerRunning=true;
                var timer = setTimeout('SwitchPic(pic)', 4000);  
            }
            function SwitchPic(pic) {
                pic.src = "pic2.jpg";
            }
        </script>
    </head>
    <body>
        <img class="switch" src="pic1.jpg" onclick="TimerSwitch(this)" />
    </body>
    </html>

  2. #2
    Join Date
    Feb 2010
    Posts
    184
    Timeout executes the code globally so pic isn't defined. You need closure.

    Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml">
      <head>
        <title></title>
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
        <script type="text/javascript" src="js/jquery-1.4.2.min.js"></script>
        <script type="text/javascript">
          function TimerSwitch(pic) {
            TimerRunning=true;
            var timer = setTimeout(function() { SwitchPic(pic) }, 4000);
          }
          function SwitchPic(pic) {
            pic.src = "pic2.jpg";
          }
        </script>
      </head>
      <body>
        <img class="switch" src="pic1.jpg" alt="something" onclick="TimerSwitch(this)" />
      </body>
    </html>

  3. #3
    Join Date
    Feb 2006
    Posts
    3
    Thank you for the quick answer, it works perfectly

  4. #4
    Join Date
    Aug 2007
    Posts
    3,767
    Code:
            function TimerSwitch(pic) {
                TimerRunning=true;
                var timer = setTimeout(function () {SwitchPic(pic);}, 4000);  
            }
    Has to be global if you pass a string to setTimeout.

    EDIT: Answered already, didn't see that.

  5. #5
    Join Date
    Aug 2013
    Posts
    1
    <head>

    <title>SLIDESHOW</title>

    <style type="text/css">
    body{background-color:black;color:white;}
    h1{font-family:tahoma;text-align:center;font-weight:bold;}
    #img{display:-webkit-box;-webkit-box-pack:center;opacity:0.8;}
    </style>
    <script type="text/javascript">
    var arr = new array();

    arr[0]= new image();
    arr[0].src = "1.jpg";

    arr[1]= new image();
    arr[1].src = "2.jpg";

    arr[2]= new image();
    arr[2].src = "2.jpg";

    </script>
    </head>
    <body onLoad="slide();">
    <h1>WELCOME</h1>
    <div id="img"><img id="image1" height="400px" width="600px" border="5" style="border-color:white;" /></div>

    <script type="text/javascript">
    var i=0;
    function slide() {
    document.getElementById("image1").src= arr[i];
    i++;
    if(i==arr.length){i=0;};
    setTimeout("slide()",2000);
    }
    </script>

    </body>
    </html>

    please help me out with this code.. i tried my level best but failed..

  6. #6
    Join Date
    Jun 2004
    Location
    Portsmouth UK
    Posts
    2,709
    Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
        "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    
    <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
    
    <head>
      <title></title>
    <style type="text/css">
    body{background-color:black;color:white;}
    h1{font-family:tahoma;text-align:center;font-weight:bold;}
    #img{display:-webkit-box;-webkit-box-pack:center;opacity:0.8;}
    </style>
    <script type="text/javascript">
    
    var arr = [];
    
    arr[0]= new Image();
    arr[0].src = "http://www.vicsjavascripts.org.uk/StdImages/1.gif";
    
    arr[1]= new Image();
    arr[1].src = "http://www.vicsjavascripts.org.uk/StdImages/2.gif";
    
    arr[2]= new Image();
    arr[2].src = "http://www.vicsjavascripts.org.uk/StdImages/3.gif";
    
    var i=0;
    
    function slide(){
     document.getElementById("image1").src= arr[i].src;
     i++;
     if(i==arr.length){
      i=0;
     }
     setTimeout(function(){ slide(); },2000);
    }
    
    </script>
    </head>
    
    <body onLoad="slide('image1',arr);">
    <h1>WELCOME</h1>
    <div id="img"><img id="image1" height="400px" width="600px" border="5" style="border-color:white;" /></div>
    
    
    
    </body>
    
    </html>
    Vic

    God loves you and will never love you less.

    http://www.vicsjavascripts.org/Home.htm
    If my post has been useful please donate to http://www.operationsmile.org.uk/

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.21709 seconds
  • Memory Usage 2,892KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (4)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (6)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (6)postbit
  • (6)postbit_onlinestatus
  • (6)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates