www.webdeveloper.com
Results 1 to 7 of 7

Thread: if/else statement cleanup. It works, but I think it could be much tidier.

Threaded View

  1. #1
    Join Date
    Aug 2013
    Location
    Dallas, TX
    Posts
    4

    Question if/else statement cleanup. It works, but I think it could be much tidier.

    Ok so I wanted to write some PHP that would display if a store was open or closed during its operation hours. My current code displays this: "The time is: hh:mm am/pm and we are currently open/closed." Which is exactly what I want it to do, but it just seems overly complicated and messy to me. I just started learning PHP this week and am looking for a little insight to clean coding I guess.

    Here is what I have:

    PHP Code:
    <?php 

    $date 
    = new DateTime(date('h:i'));
    $date -> modify('-25200 seconds');
    $day date('w');
    $time =  date('H');
    $hoursTueWedFri = array(1617181920212223);
    $hoursThu = array(001617181920212223);
    $hoursSat = array(16171819202122);
    //time is 7 hrs ahead

    <p>The time is: <?php echo $date->format('g:i a'); ?> and we are currently 

    <?php

        
    if ($day == 0) { 
            echo 
    "closed"
        } 

        if (
    $day == 1) { 
            echo 
    "closed"
        }

        if (
    $time == $hoursTueWedFri) { 
            echo 
    "open"
        }

        elseif (
    $time == $hoursThu) { 
            echo 
    "open"
        } 

        elseif (
    $time == $hoursSat) { 
            echo 
    "open"
        } 

        else { 
            echo 
    "closed"
        }

    //Store Hours:
    //Sunday - CLOSED 
    //Monday - CLOSED 
    //Tuesday 9:00 AM - 6:00 PM = 16 - 23
    //Wednesday 9:00 AM - 6:00 PM = 16 - 23
    //Thursday 9:00 AM - 7:00 PM = 16 - 00 
    //Friday 9:00 AM - 6:00 PM  = 16 - 23
    //Saturday 9:00 AM - 5:00 PM = 16 - 22

    ?>.</p>
    You'll notice that I modified the date for my time zone. This isn't urgent or anything, I just want to try and learn how to clean my code up so I can get better!

    Thoughts?
    Last edited by NogDog; 08-28-2013 at 11:07 PM. Reason: changed CODE tags to PHP tags

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.12133 seconds
  • Memory Usage 3,256KB
  • Queries Executed 14 (?)
More Information
Template Usage (32):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)bbcode_html
  • (6)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)showthread_list
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (27):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./includes/functions_threadedmode.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (73):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids_threaded
  • showthread_threaded_construct_link
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates