www.webdeveloper.com
Results 1 to 7 of 7

Thread: if/else statement cleanup. It works, but I think it could be much tidier.

Threaded View

  1. #1
    Join Date
    Aug 2013
    Location
    Dallas, TX
    Posts
    4

    Question if/else statement cleanup. It works, but I think it could be much tidier.

    Ok so I wanted to write some PHP that would display if a store was open or closed during its operation hours. My current code displays this: "The time is: hh:mm am/pm and we are currently open/closed." Which is exactly what I want it to do, but it just seems overly complicated and messy to me. I just started learning PHP this week and am looking for a little insight to clean coding I guess.

    Here is what I have:

    PHP Code:
    <?php 

    $date 
    = new DateTime(date('h:i'));
    $date -> modify('-25200 seconds');
    $day date('w');
    $time =  date('H');
    $hoursTueWedFri = array(1617181920212223);
    $hoursThu = array(001617181920212223);
    $hoursSat = array(16171819202122);
    //time is 7 hrs ahead

    <p>The time is: <?php echo $date->format('g:i a'); ?> and we are currently 

    <?php

        
    if ($day == 0) { 
            echo 
    "closed"
        } 

        if (
    $day == 1) { 
            echo 
    "closed"
        }

        if (
    $time == $hoursTueWedFri) { 
            echo 
    "open"
        }

        elseif (
    $time == $hoursThu) { 
            echo 
    "open"
        } 

        elseif (
    $time == $hoursSat) { 
            echo 
    "open"
        } 

        else { 
            echo 
    "closed"
        }

    //Store Hours:
    //Sunday - CLOSED 
    //Monday - CLOSED 
    //Tuesday 9:00 AM - 6:00 PM = 16 - 23
    //Wednesday 9:00 AM - 6:00 PM = 16 - 23
    //Thursday 9:00 AM - 7:00 PM = 16 - 00 
    //Friday 9:00 AM - 6:00 PM  = 16 - 23
    //Saturday 9:00 AM - 5:00 PM = 16 - 22

    ?>.</p>
    You'll notice that I modified the date for my time zone. This isn't urgent or anything, I just want to try and learn how to clean my code up so I can get better!

    Thoughts?
    Last edited by NogDog; 08-28-2013 at 11:07 PM. Reason: changed CODE tags to PHP tags

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles