www.webdeveloper.com
Results 1 to 3 of 3

Thread: trying to update

  1. #1
    Join Date
    Apr 2013
    Location
    gastonia NC
    Posts
    118

    trying to update

    Hello all, I have this one record database file used to hold several last used values, I've confirmed validity of the record. I don't get an error so ....? Will someone take look at this feeble attempt and advise?
    thanks in advance!
    :
    PHP Code:
    <?php 
    // error_reporting(0);
    error_reporting(E_ALL E_NOTICE); 
    mysql_connect("localhost","root",""); 
    mysql_select_db("numbersdb") or die( "Unable to select database"); 
    if(!empty(
    $_POST["submit"])) 

     
    $taxrate $_POST['taxrate']; 
     
    $query="SELECT * FROM numbdata Where id='$id'"
     
    $result=mysql_query($query); 
     if(
    mysql_num_rows($result)) 
     {  
    }else{echo 
    "No listing for taxrate $taxrate .<br />Select another? .<br />";} 

    if(!empty(
    $_POST["update"])) 

    $sql "UPDATE numbdata SET 
    taxrate = '" 
    .mysql_real_escape_string($_POST['taxrate']) . "', 
    WHERE taxrate='"
    .$_POST['taxrate']."'"
    mysql_query($sql) or die(mysql_error());
     echo 
    "Record for taxrate ".$_POST["taxrate"]." has been updated"
     } 
    ?>

  2. #2
    Join Date
    Jul 2013
    Location
    Voorheesville NY USA
    Posts
    1,900
    Perhaps it is because you grab the 'taxrate' input value but do a query on whatever the value of $id is? Should that be perhaps '$taxrate'?

  3. #3
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,328
    See comments...
    PHP Code:
    <?php
    // error_reporting(0);
    // get rid of "^ E_NOTICE" for now, might get useful info <---------<<<<<<<
    error_reporting(E_ALL E_NOTICE);
    mysql_connect("localhost""root""");
    mysql_select_db("numbersdb") or die("Unable to select database");
    if (!empty(
    $_POST["submit"])) 
    {
        
    $taxrate $_POST['taxrate'];
        
    // where is $id set?  <---------------<<<<<<<<<<<<<<<<<<<<<
        
    $query "SELECT * FROM numbdata Where id='$id'"
        
    $result mysql_query($query);
        if (
    mysql_num_rows($result)) 
        {
        }
        else
        {
            echo 
    "No listing for taxrate $taxrate .<br />Select another? .<br />";
        }
    }
    if (!empty(
    $_POST["update"])) 
    {
        
    // why set taxrate to value where taxrate already equals value?  <---<<<<<
        
    $sql "UPDATE numbdata SET
    taxrate = '" 
    mysql_real_escape_string($_POST['taxrate']) . "',
    WHERE taxrate='" 
    $_POST['taxrate'] . "'";
        
    mysql_query($sql) or die(mysql_error());
        
    // query can succeed yet not update anything if no match for WHERE
        // might want to check mysql_affected_rows() to see if anything
        // was actually updated   <-----------------------<<<<<<<<<
        
    echo "Record for taxrate " $_POST["taxrate"] . " has been updated";
    }
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.15414 seconds
  • Memory Usage 2,881KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates