www.webdeveloper.com
Results 1 to 2 of 2

Thread: Underline Bookmarklet

  1. #1
    Join Date
    Oct 2013
    Posts
    1

    Underline Bookmarklet

    I am developing an underline bookmarklet. It was designed to work in any text box but it only seems to work in Yahoo mail. I have no idea why. I have included it below. Line breaks and comments have been added. In reality it is one line that goes in the address of the bookmark. When it works inputString has a value. When it doesn't work (which is everywhere but Yahoo mail) inputString is blank.
    It is available for testing at http://dmmarks.com/bookmarklets.html

    Code:
    javascript:
    /* function to convert HTML entities to text */
    function%20get_ents(str)
    {var%20temp=document.createElement('pre');
    temp.innerHTML=str;
    return%20temp.firstChild.nodeValue;};
    
    /* get the selected text */
    inputString=document.getSelection().getRangeAt(0); <----- problem seems to be here
    inputChar='';
    outputChar='';
    
    /* convert to string so length will work */
    selectedText%20=%20inputString.toString();
    
    /* add the underline charaters */
    for(i=0;i<selectedText.length;i++)
    {outputChar=outputChar+selectedText.charAt(i).concat('%CC%B2')};
    
    /* replace the selected text */
    inputString.deleteContents();
    inputString.insertNode(document.createTextNode(get_ents(outputChar)));
    void(0);

  2. #2
    Join Date
    Nov 2002
    Location
    Flint, Michigan, USA
    Posts
    652
    You need a bit more work to properly get the selected text. I use this subroutine:
    Code:
    //  getselec.js  Get selected text
    //  Written:  2013-05-30 by James Alarie
    //    http://spruce.flint.umich.edu/~jalarie/
    //  Title=Pick up highlighted text from the web page.
    //  Keywords=select,highlight,text.
    //
    //  Functions:
    //    GetSelected(What)
    //      What      optional      The prompt to use if nothing is selected.
    //      if nothing is selected and "What" is null, a null value is returned.
    
      function GetSelected(What) {
        var Value;
        if (window.getSelection) {
          Value=window.getSelection();
        } else {
          if (document.getSelection) {
            Value=document.getSelection();
          } else {
            Value=document.selection.createRange().text;
          }
        }
        if (Value == '') {
          if (What) {
            Value=prompt(What,'');
          }
        }
        return Value+'';
      } // GetSelected

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.16157 seconds
  • Memory Usage 2,836KB
  • Queries Executed 13 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (2)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates