www.webdeveloper.com
Results 1 to 7 of 7

Thread: Is there a simpler way to write this?

  1. #1
    Join Date
    Jan 2005
    Location
    Alicante (Spain)
    Posts
    7,742

    Is there a simpler way to write this?

    PHP Code:
    # enter the clause only if more than one of the following is negative. And they are all string values.
    if(false === 
        (
            (
    $uncommittedDiseqcCommand == "0" and $commitedDiseqcCommand == "none") or 
            (
    $toneburst == "none" and $commitedDiseqcCommand == "none") or 
            (
    $uncommittedDiseqcCommand == "0" and $toneburst == "none")
        )
    )
    {
        ...


  2. #2
    Join Date
    Dec 2002
    Location
    Seattle, WA
    Posts
    1,843
    check for negatives, i.e. "0" and "none"?
    PHP Code:
    if(($uncommittedDiseqcCommand === '0' || $uncommittedDiseqcCommand === 'none') || $toneburst === 'none') {
        
    // ...

    Note: "AND" and "OR", and "&&" and "||" behave differently.

  3. #3
    Join Date
    Jan 2005
    Location
    Alicante (Spain)
    Posts
    7,742

  4. #4
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,284
    Not that I really like this, but I figured I'd post it here anyway in case it gives you a different way to think about it, at least:
    PHP Code:
    if(array_sum(array(
        (
    $uncommittedDiseqcCommand == "0") ? 0,
        (
    $toneburst == "none") ? 0,
        (
    $commitedDiseqcCommand == "none") ? 0
    )) < 2)
    {
        
    //

    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  5. #5
    Join Date
    Jan 2005
    Location
    Alicante (Spain)
    Posts
    7,742
    Thanks for the idea Nogdog. Not much simpler for 3 compared to mine but for 4 or more would be much simpler. Also I don't think you need the array stuff. Something like this...
    PHP Code:
    if(
        (((
    $uncommittedDiseqcCommand == "0") ? 0) +
        ((
    $toneburst == "none") ? 0) +
        ((
    $commitedDiseqcCommand == "none") ? 0))
        < 
    2)
    {
        
    //


  6. #6
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,284
    See, I knew you could make something useful out of it. Probably more efficient without building the array, too.
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  7. #7
    Join Date
    Dec 2002
    Location
    Seattle, WA
    Posts
    1,843
    I didn't notice the $commitedDiseqcCommand.
    this works:
    PHP Code:
    if (!(($commitedDiseqcCommand === 'none' && $uncommittedDiseqcCommand === '0') || $toneburst === 'none')) {
        
    // ...

    tests:
    PHP Code:
    <?php
    function test1($commitedDiseqcCommand$uncommittedDiseqcCommand$toneburst)
    {
        return !((
    $commitedDiseqcCommand === 'none' && $uncommittedDiseqcCommand === '0') || $toneburst === 'none');
    }
    function 
    test2($commitedDiseqcCommand$uncommittedDiseqcCommand$toneburst)
    {
        return ((((
    $uncommittedDiseqcCommand == "0") ? 0) + (($toneburst == "none") ? 0) + (($commitedDiseqcCommand == "none") ? 0)) < 2);
    }
    function 
    test3($commitedDiseqcCommand$uncommittedDiseqcCommand$toneburst)
    {
        return (
    false === 
        (
            (
    $uncommittedDiseqcCommand == "0" and $commitedDiseqcCommand == "none") or 
            (
    $toneburst == "none" and $commitedDiseqcCommand == "none") or 
            (
    $uncommittedDiseqcCommand == "0" and $toneburst == "none")
        )
    );
    }
    function 
    x($a$b$c)
    {
        echo 
    '<p>test 1: ', (test1($a$b$c) ? 'true' 'false'), '<br>';
        echo 
    'test 2: ', (test2($a$b$c) ? 'true' 'false'), '<br>';
        echo 
    'test 3: ', (test3($a$b$c) ? 'true' 'false'), '</p>';
    }
    x('none''0''none');
    x('none''1''none');
    x('none''0''something');
    x('something''0''none');
    x('something''1''something');
    x('something''0''something');
    ?>
    Last edited by ShrineDesigns; 05-01-2014 at 07:01 PM.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.44055 seconds
  • Memory Usage 2,960KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (6)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (70):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • bbcode_parse_start
  • postbit_imicons
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates