www.webdeveloper.com
Results 1 to 5 of 5

Thread: Problem with using variable values in PDO update statement

  1. #1
    Join Date
    Nov 2013
    Posts
    17

    Problem with using variable values in PDO update statement

    Hi guys!
    I have a slight problem. When I pass values as variables to a sql statement it doesnt work. This is the example:

    THIS WORKS:

    <?php
    require 'DB/dbinc.php';


    try {
    // Connect and create the PDO object
    $conn = new PDO("mysql:host=$dbhost; dbname=$dbname", $usernm, $dbpass);
    $conn->exec("SET CHARACTER SET utf8"); // Sets encoding UTF-8

    // changes data in "name" si "link" colummns, where id=3
    $sql = "UPDATE bloging SET title='Novi Title', tekst='Novi tekst' WHERE title='Update post'";
    $count = $conn->exec($sql);

    $conn = null; // Disconnect
    }
    catch(PDOException $e) {
    echo $e->getMessage();
    }

    // If data added ($count not false) displays the number of rows added
    if($count !== false) echo 'Number of rows added: '. $count;
    ?>
    THIS DOES NOT WORK
    <?php
    require 'DB/dbinc.php';
    $oldTitle = 'Stari naslov';
    $nTitle = 'novinaslov';
    $nText = 'novitekst';

    try {
    // Connect and create the PDO object
    $conn = new PDO("mysql:host=$dbhost; dbname=$dbname", $usernm, $dbpass);
    $conn->exec("SET CHARACTER SET utf8"); // Sets encoding UTF-8

    // changes data in "name" si "link" colummns, where id=3
    $sql = "UPDATE bloging SET title=$nTitle, tekst=$nText WHERE title=$oldTitle";
    $count = $conn->exec($sql);

    $conn = null; // Disconnect
    }
    catch(PDOException $e) {
    echo $e->getMessage();
    }

    // If data added ($count not false) displays the number of rows added
    if($count !== false) echo 'Number of rows added: '. $count;
    ?>

    THANK YOU IN ADVANCE!

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,285
    Make use of bound parameters, so that you don't have to worry about quoting and escaping data:
    PHP Code:
    // changes data in "name" si "link" colummns, where id=3
    $sql "UPDATE bloging SET title=:nTitle, tekst=:nText WHERE title=:oldTitle";
    $stmt $conn->prepare($sql);
    if(
    $stmt == false) {
        throw new 
    Exception(print_r($conn->errorInfo(),1).PHP_EOL.$sql);
    }
    $result $stmt->execute(
        array(
            
    ':nTitle'   => $nTitle,
            
    ':nText'    => $nText,
            
    ':oldTitle' => $oldTitle
        
    )
    );
    if(
    $result == false) {
        throw new 
    Exception(print_r($stmt->errorInfo(),1).PHP_EOL.$sql);
    }
    $count $stmt->rowCount(); 
    PS: You can help us help you by making use of this forum's [php], [code], and [html] tags around applicable code snippets.
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  3. #3
    Join Date
    Nov 2013
    Posts
    17

    Now it reports "Internal Server Error"

    The code that doesn't work did not report any error. It just didn't do anything. Now I copyied your code and reports error? Any idea where is the problem? Also I don't get it why it wont accept variable instead of string text as a value? It works just fine with db connection! But not for update!?
    Sorry for not putting code in quotes b4.

    Thanx in advance.

    PHP Code:
    <?php
    require 'DB/dbinc.php';

    $oldTitle 'Stari naslov';
    $nTitle 'novinaslov';
    $nText 'novitekst';

    try {
    // Connect and create the PDO object
    $conn = new PDO("mysql:host=$dbhost; dbname=$dbname"$usernm$dbpass);
    $conn->exec("SET CHARACTER SET utf8"); // Sets encoding UTF-8

    // changes data in "bloging" for "title" and "post"  where title = some title
    $sql "UPDATE bloging SET title=:nTitle, tekst=:nText WHERE title=:oldTitle"
    $stmt $conn->prepare($sql); 
    if(
    $stmt == false) { 
        throw new 
    Exception(print_r($conn->errorInfo(),1).PHP_EOL.$sql); 

    $result $stmt->execute
        array( 
            
    ':nTitle'   => $nTitle
            
    ':nText'    => $nText
            
    ':oldTitle' => $oldTitle 
        

    ); 
    if(
    $result == false) { 
        throw new 
    Exception(print_r($stmt->errorInfo(),1).PHP_EOL.$sql); 

    $count $stmt->rowCount();  
    ?>

  4. #4
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,285
    Probably because you have a "try {" that is not closed with a corresponding "catch" block.
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  5. #5
    Join Date
    Nov 2013
    Posts
    17

    Problem soved!

    PHP Code:
    <?php
      
    require 'DB/dbinc.php';
      
      
    $oT $_POST['starinaslov'];
      
    $nT $_POST['novinaslov'];
      
    $nTx $_POST['novitekst'];
      
      try {
      
    // Connect and create the PDO object
     
    $conn = new PDO("mysql:host=$dbhost; dbname=$dbname"$usernm$dbpass);
     
    $conn->exec("SET CHARACTER SET utf8"); // Sets encoding UTF-8
     
     //Update
     
    $sql "UPDATE bloging SET title=:ntitle, tekst=:ntext WHERE title=:oldtitle";
     
    $stmt $conn->prepare($sql);
     
    $stmt->execute(array(
       
    ':ntitle' => $nT
       
    ':ntext' => $nTx
       
    ':oldtitle' => $oT
     
    ));
     
     
    $conn null// Disconnect
     
    }
     catch(
    PDOException $e) {
     echo 
    $e->getMessage();
     }
     
     
    ?>

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.34779 seconds
  • Memory Usage 2,919KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (3)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (5)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates