www.webdeveloper.com
Results 1 to 8 of 8

Thread: isset doesnt work.

  1. #1
    Join Date
    Feb 2014
    Posts
    4

    isset doesnt work.

    Im trying to make form and I want if the field is empty it doesnt show it at all, but it shows anyway.

    <form action="form.php" method="get">
    <fieldset style="width: 250px;">
    <legend>Register Form</legend>

    <!-- name, surname, email, password -->
    <label>First name: <input type="text" name="firstname"></label><br>
    <label>Last name: <input type="text" name="lastname"></label><br>
    <label>E-mail: <input type="text" name="email" size="24"></label><br>
    <label>Password: <input type="password" name="password"></label><br>

    <!-- gender -->
    <label for="gender">Gender:
    <input type="radio" name="gender" value="M" /> Male
    <input type="radio" name="gender" value="F" /> Female</p>
    </label>

    <!-- drop down menu -->
    <label>Age:
    <select name="age">
    <option value="0-29">Under 30</option>
    <option value="30-60">Between 30 and 60</option>
    <option value="60+">Over 60 </option>
    </select>
    </label><br>

    <!-- comment -->
    <label>Comments: <textarea name="comments" rows="3" cols="40"></textarea>

    </fieldset>
    <!-- submit button -->
    <input type="submit" value="Submit" name="submit">

    </form>


    and

    <?php

    $firstname = $_REQUEST['firstname'];
    $lastname = $_REQUEST['lastname'];
    $email = $_REQUEST['email'];
    $password = $_REQUEST['password'];
    $gender = $_REQUEST['gender'];
    $age = $_REQUEST['age'];

    if (isset($_REQUEST['firstname']))
    echo 'Firstname is: ' . $firstname;
    if (isset($_REQUEST['lastname']))
    echo '<br>Lastname is: ' . $lastname;
    echo '<br>Email is: ' . $email;
    echo '<br>Password is: ' . $password;
    echo '<br>Gender is: ' . $gender;
    echo '<br>Age is: ' . $age;

    Why it shows lines under if? And when I use chrome it shows me Notice: Undefined index: gender in C:\xampp\htdocs\form.php on line 7. but there is nothing wrong. :/

  2. #2
    Join Date
    Jul 2013
    Location
    Voorheesville NY USA
    Posts
    1,882
    Don't understand your question. Can you be more exact about "under if"?

    Also - you should not use GET to pass all this data. Use POST and never check the REQUEST array for your input values.

    <form method="POST">
    and

    $firstname = $_POST['firstname'];

    would be the right way.

  3. #3
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,288
    Here's a little trick you can do with variable variables:
    PHP Code:
    $fields = array(
        
    'firstname',
        
    'lastname',
        
    'email',
        
    'password',
        
    'gender',
        
    'age'
    );
    foreach(
    $fields as $field) {
        ${
    $field} = '';
        if(isset(
    $_POST[$field])) {
            ${
    $field} = trim($_POST[$field]);
        }
    }
    // each of those fields should now exist as a variable, e.g.:
    echo "Email: $email"
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  4. #4
    Join Date
    Feb 2014
    Posts
    4
    Quote Originally Posted by ginerjm View Post
    Don't understand your question. Can you be more exact about "under if"?

    Also - you should not use GET to pass all this data. Use POST and never check the REQUEST array for your input values.

    <form method="POST">
    and

    $firstname = $_POST['firstname'];

    would be the right way.
    I changed to $_POST, but still it doesnt work.
    if (isset($firstname))
    echo 'First name is: ' . $firstname;
    It shows anyway if its empty or if it has a value.

  5. #5
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,288
    Remember that isset() just means the variable is defined, not whether or not it is an empty string. Use empty() for that test (but remember that a value of 0 is empty).
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  6. #6
    Join Date
    Feb 2014
    Posts
    4
    Thanks you guys for helping. Got what I wanted.
    Final Result

    <?php

    $fields = array(
    'firstname',
    'lastname',
    'email',
    'password',
    'gender',
    'age'
    );
    foreach($fields as $field) {
    ${$field} = '';
    if(isset($_POST[$field])) {
    ${$field} = trim($_POST[$field]);
    }
    }
    // each of those fields should now exist as a variable, e.g.:
    if (!empty($firstname))
    echo "Firstname: $firstname<br>";
    if (!empty($lastname))
    echo "Lastname: $lastname<br>";
    if (!empty($email))
    echo "Email: $email<br>";
    if (!empty($password))
    echo "Password: $password<br>";
    if (!empty($gender))
    echo "Gender: $gender<br>";
    if (!empty($age))
    echo "Age: $age<br>";

    ?>

  7. #7
    Join Date
    Feb 2014
    Posts
    4
    0 is a value can be fixed: if (!empty($firstname) || $firstname == 0)

  8. #8
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,288
    Another test I've used to make sure they entered something:
    PHP Code:
    if(trim($_POST['foo']) === '') { // note use of "is identical to" operator
        // it's blank or just white-space

    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.18980 seconds
  • Memory Usage 2,924KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (8)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (8)postbit
  • (8)postbit_onlinestatus
  • (8)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates