www.webdeveloper.com
Results 1 to 5 of 5

Thread: [RESOLVED] How do I correct this piece of code?

  1. #1
    Join Date
    Mar 2014
    Posts
    8

    resolved [RESOLVED] How do I correct this piece of code?

    I have this piece of code. But I'm getting syntax errors and I'm not sure how to format it correctly. The echo $_SESSION['username'] part is not correct I think.

    Code:
    //query the database
    $query = mysql_query("SELECT * FROM users WHERE username = echo $_SESSION['username']");
    Thanks!

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,327
    You don't need an echo. Instead, you'll be using string concatenation with the "." operator. (Well, it's one common way to do it, anyway -- there are a few other options I won't bother you with for now.)
    PHP Code:
    $query mysql_query("SELECT * FROM users WHERE username '".mysql_real_escape_string($_SESSION['username'])."'"); 
    I'll leave it up to you to research why I added the call to mysql_real_escape_string(), but here's a hint.
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  3. #3
    Join Date
    Mar 2014
    Posts
    8
    Thanks for your quick reply.
    I did what you suggested which got rid of the syntax error. Nice explanation

    Now it says "mysql_fetch_array(): supplied argument is not a valid MySQL result resource in path/index.php on line 19". I did some research and tried to look for any errors in the remaining code but couldn't find any. Could you please take a quick look at it? Thanks.

    Its able to connect to database ok. When I echo the username by just putting in
    Code:
     echo $_SESSION['username'];
    at the top of the script it works, but I need it to echo other data from the database based on the current username.

    Line 19 is the line with WHILE...

    Code:
    //connect to the server
    $connect = mysql_connect("localhost","users","password");
    
    //connect to the database
    mysql_select_db("users");
    
    //query the database
    $query = mysql_query("SELECT * FROM users WHERE username '".mysql_real_escape_string($_SESSION['username'])."'");
    
    //fetch the results
    	WHILE($rows = mysql_fetch_array($query)):
    		$username = $rows['username'];
                    $email = $rows['coins']
    	
    	echo "Welcome $username!!! <br> You have $coins coins.";
    	
    	endwhile;

  4. #4
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,327
    99% of the time, that means the database did not understand your query, so mysql_query() returned false instead of a query result resource. Try adding some debug code after the query call to find out why. (Also, to help with that, I like to define the query string separately so we can reference it in the error output.)
    PHP Code:
    //query the database
    $sql "SELECT * FROM users WHERE username '".mysql_real_escape_string($_SESSION['username'])."'";
    $query mysql_query($sql);
    if(
    $query == false) {
        throw new 
    Exception("Query failed: ".mysql_error().PHP_EOL.$sql);
    }

    // rest of code... 
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  5. #5
    Join Date
    Mar 2014
    Posts
    8

    Cool

    Thanks a lot! I found the problem - I had double quotes instead of single quotes somewhere in the code. Its working now.


    Thanks!

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.11191 seconds
  • Memory Usage 2,882KB
  • Queries Executed 13 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (3)bbcode_code
  • (2)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (5)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates