www.webdeveloper.com
Results 1 to 7 of 7

Thread: [RESOLVED] MySQL UPDATE WHERE NOT EQUAL not working

  1. #1
    Join Date
    Dec 2011
    Posts
    181

    resolved [RESOLVED] MySQL UPDATE WHERE NOT EQUAL not working

    I am currently finishing up part of my theme manager page, but have hot a roadblock

    My code is follows...

    PHP Code:
    <?php
        
    if($_POST['submit']){
            
    $name mysqli_prep($_POST['name']);
            
    // SET PREVIOUSLY ACTIVE THEME TO INACTIVE
            
    $sql "UPDATE themes SET
                    active = 0
                    WHERE (active = 1 AND name != 
    $name)
                    LIMIT 1"
    ;
            
    $result mysqli_query($connect$sql);
            echo 
    "Confirming Inactive Theme...\n";
            
    confirm_query($result);
            if(
    $result){
                echo 
    "Theme Unselected";
            }
            
    // SET SELECTED THEME TO ACTIVE
            
    $sql "UPDATE themes SET
                    active = 1
                    WHERE name = 
    $name
                    LIMIT 1"
    ;
            
    $result mysqli_query($connect$sql);
            echo 
    "Confirming Active Theme...\n";
            
    confirm_query($result);
            if(
    $result){
                echo 
    "Theme Selected";
            }
            
    //redirect_to("/home/admin/themes.php");
        
    }
    ?>
    I get the following in the browser...

    Code:
    Confirming Inactive Theme... Database query failed: Unknown column 'Easter' in 'where clause'
    I have no clue what's going on, I must have missed something, but can't figure it out.

  2. #2
    Join Date
    Mar 2005
    Location
    Behind you...
    Posts
    1,159
    Out of curiosity, perhaps you should echo the $sql variable just to see what the full query that is being processed ends up looking like. Also, I'm not really an expert on SQL, but I don't see why you need the parenthesis around your WHERE clause. It shouldn't be needed at all, but I can't say it's causing your issue. In either case I'd pull it off and give the query another whirl.
    "Given billions of tries, could a spilled bottle of ink ever fall into the words of Shakespeare?"

  3. #3
    Join Date
    Jul 2013
    Location
    Voorheesville NY USA
    Posts
    1,882
    Is $name an integer or a string? If the field it is being matched to is not a numeric one, you need quotes around $name.

  4. #4
    Join Date
    Dec 2011
    Posts
    181
    $name is a string

    echoed $sql

    This is what happened after I put the LIMIT 1 in it...

    Code:
    UPDATE themes SET active = 0 WHERE (active = 1 AND name != Default) LIMIT 1
    Confirming Inactive Theme... 
    Database query failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') LIMIT 1' at line 3
    Taking away parenthesis doesn't change anything.
    Last edited by Dragonfire2008; 03-31-2014 at 01:19 PM.

  5. #5
    Join Date
    Mar 2005
    Location
    Behind you...
    Posts
    1,159
    But now after looking at your SQL, you should follow ginerjm's note on putting quotations around your $name value since it is a string. As you can see in your query you are checking "name != Default" which is invalid. It should read "name != 'Default'".
    "Given billions of tries, could a spilled bottle of ink ever fall into the words of Shakespeare?"

  6. #6
    Join Date
    Dec 2011
    Posts
    181
    Huh, don't remember having that problem, but anyways that did it! Thanks.

  7. #7
    Join Date
    Jul 2013
    Location
    Voorheesville NY USA
    Posts
    1,882
    If you are using normal queries (as in, not 'prepared') you must quote any argument that is not a number.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.43598 seconds
  • Memory Usage 2,914KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (1)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (7)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (7)postbit
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates