www.webdeveloper.com
Results 1 to 4 of 4

Thread: Writing javascript inside PHP Echo

  1. #1
    Join Date
    Jun 2014
    Posts
    6

    Writing javascript inside PHP Echo

    Hello,
    i'm trying to write javascript inside a PHP Echo but it isin't working. Here's the Javascript which i'm trying to embed in PHP:

    Code:
    <form id="myForm" action="" method="post">
    
    <div>
    <h4 >Samsung Option: 
     <select id="products" onchange="document.getElementById('price').innerHTML='$'+this.value">
      <option value=""> Select </option>
      <option value="400"> Galaxy S5 </option>
      <option value="300"> Galaxy S4 </option>
      <option value="200"> Galaxy S3 </option>
      <option value="100"> Galaxy S2 </option>
     </select>
    </h4>
    </div>
    
    <div>
    <h4 id="price">Price: $</h4>
    </div>
    
    </form>

    Here's my PHP Code:


    PHP Code:

    $result_quantity 
    mysqli_query($con,"SELECT * FROM quantity_price where brand='$brand_name' AND category='$category' AND product_id='$code' ORDER BY quantity");

                         
    $num_of_rows=mysqli_num_rows($result_quantity);

                         
    $count=0;
                         
    echo 
    '<p style="font-size:0.71em">Available Packaging: <select name="product_qty" style="margin-left:4px; font-size:1.02em;" onchange="document.getElementById("price").innerHTML="$"+this.value">';

                         while(
    $row_quantity mysqli_fetch_array($result_quantity)) {
                         
                         
                         
                         echo 
    '<option value="'.$row_quantity['price'].'">'.$row_quantity['quantity'].' '.$row_quantity['quantity_unit'].'</option>';
                        }

                         echo 
    '</select></p>';

                         
    //echo '</p>';

                         
    $count=0;

                         
    $result_price mysqli_query($con,"SELECT * FROM quantity_price where brand='$brand_name' AND category='$category' AND product_id='$code'");

                         
    $num_of_rows_2=mysqli_num_rows($result_price);

                         echo 
    ' <p style="font-size:0.71em" id = "price">Price: Rs '


    Basically, the values for the select button loads from the Database. What i want is the price of those items to change through javascript.



    Any ideas on how to resolve this? thanks!

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,284
    May just be a quoting issue:
    PHP Code:
    echo '<p style="font-size:0.71em">Available Packaging: 
    <select name="product_qty" style="margin-left:4px; font-size:1.02em;" 
    onchange="document.getElementById(\'price\').innerHTML=\'$\'+this.value">'

    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  3. #3
    Join Date
    Jun 2014
    Posts
    6
    thanks thats working!

  4. #4
    Assuming your echo uses single quotes (hence your ability to use doubles) you have to escape your single quotes inside it.

    Example:
    Code:
    echo '
      <select id="products" onchange="document.getElementById(\'price\').innerHTML = \'$\' + this.value">';
    THOUGH, any script WORTH using shouldn't be using the onchange element, it should be attaching it from an external script so that across page-loads it can be cached. I'd also not use innerHTML since it forces a reparse of the whole document which can have undesired side-effects and be slower than using more code (strange as that sounds) to manipulate the DOM instead.

    Though you have one BIG error in there. A select's value is the 'index' of the OPTION inside the select. To get the option's value, you have to go through that selects child OPTION.

    = '$' + this.options[this.value].value;

    Which put altogether the markup would simply be gutted down to:
    Code:
    <select id="products">
    But the JS gets a bit more complex, but this would run faster and be the 'proper way' -- and despite being more code COULD result in the site using less bandwidth thanks to being able to put this in a file outside the markup where it can be cached. (depends on your traffic and how often you use this)
    Code:
    (function(d) { /* anonymous function to prevent scope conflicts */
    
    	/* First some handy functions */
    	
    	function addEvent(e, event, handler) {
    		if (e.addEventListener) e.addEventListener(event, handler, false);
    			else e.attachEvent('on' + event, handler);
    	}
    	
    	function flush(e) {
    		while (e.firstChild) e.removeChild(e.firstChild);
    	}
    	
    	function nodeAdd(e, data) {
    		e.appendChild(typeof data == 'object' ? data : d.createTextNode(data);
    	}
    	
    	function nodeReplace(e, data) {
    		flush(e);
    		nodeAdd(e, data);
    	}
    
    	/* the meat and bones */
    
    	var
    		products = d.getElementById('products'),
    		price = d.getElementById('price');
    	if (products) addEvent(products, 'change', function(e) {
    		nodeReplace(price, products.options[products.value].value);
    	});
    
    })(document);
    /* I pass document to make the code smaller/faster inside the anon */
    A bit more complex -- I have equivalents to those 'handy functions' in my elementals library, which using elementals would go like this:

    Code:
    (function() {
    	var
    		products = _d.get('#products'),
    		price = _d.get('#price');
    	if (products) products.addHandler('change', function(e, t) {
    		price.nodeReplace(products.options[products.value].value);
    	});
    })();
    Hope this helps. Any questions fire away.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.35054 seconds
  • Memory Usage 2,890KB
  • Queries Executed 15 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (5)bbcode_code
  • (2)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (4)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates