www.webdeveloper.com
Results 1 to 2 of 2

Thread: Trying to update database record but getting error

  1. #1
    Join Date
    Jul 2014
    Posts
    1

    Trying to update database record but getting error

    Hi

    So I'm new to php and followed some tutorials with updating records in a database. The tutorial I followed seems to work for them, but doesnt work for me and I get this error which I dont fully understand. Going to the edit page, the id in the url is correct, and it populates the input fields correctly, its just when i hit update i get the error.

    The error is as follows:
    Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in /home5/canaryde/public_html/m/reviews/edit_review.php on line 8

    PHP Code:
    <?php include '../includes/db_connect.php';
        
        
    $query " SELECT * FROM brads_reviews WHERE ID = $_GET[id] ";
        
    $result mysql_query($query);
        
    $show mysql_fetch_array($result);
        
    ?>
        
        <div class="container-fluid">
            <div class="row">
                
                <?php include '../includes/left_menu.php'?>

                <div class="col-lg-10 content-container">
                    <form role="form" action="<?php echo htmlentities($_SERVER['PHP_SELF']);?>" method="post">
                      <div class="form-group" style="display: none;">
                        <input type="text" class="form-control" value="<?php echo $show['review_date']; ?>" name="review_date" >
                      </div>
                      <div class="form-group">
                        <label for="artist_name">Artist Name</label>
                        <input type="text" class="form-control" name="artist_name" value="<?php echo $show['artist_name']; ?>">
                      </div>
                      <div class="form-group">
                        <label for="release_title">Release Title</label>
                        <input type="text" class="form-control" name="release_title" value="<?php echo $show['release_title']; ?>">
                      </div>
                      <div class="form-group">
                          <p>Currently rated: <?php echo $show['rating']; ?></p>
                          <br />
                        <label for="rating">Change Rating&nbsp;</label>
                        <select class="combobox" name="rating">
                            <option value="zero">0</option>
                            <option value="pointfive">0.5</option>
                            <option value="one">1</option>
                            <option value="onepointfive">1.5</option>
                            <option value="two">2</option>
                            <option value="twopointfive">2.5</option>
                            <option value="three">3</option>
                            <option value="threepointfive">3.5</option>
                            <option value="four">4</option>
                            <option value="fourpointfive">4.5</option>
                            <option value="five">5</option>
                        </select>
                      </div>
                      <div class="form-group">
                        <label for="review">Review</label>
                        <textarea type="text" class="form-control" name="review" id="editor_review" style="height: 10em;"><?php echo $show['review']; ?></textarea>
                      </div>
                      <div class="form-group">
                          <p>Currently Approved? <?php echo $show['approved']; ?></p>
                          <br />
                          <label for="review">Change Status&nbsp;</label>
                        <select class="combobox" name="approved">
                            <option value="Yes">Yes</option>
                            <option value="No">No</option>
                            <option value="Pending">Pending</option>
                        </select>
                      </div>
                      <input type="hidden" name="id" value="<?php echo $_GET['id']; ?>" />
                      <button type="submit" class="btn btn-primary">Update</button>
                    </form>
                </div>

            </div>

        </div>

        <?php include '../includes/javascript.php'?>
        
        <script>
            CKEDITOR.replace( 'editor_review' );
        </script>

        <?php 
        
    if(isset($_POST['submit'])) {
             
    $update "UPDATE brads_reviews SET `artist_name`='$_POST[artist_name]', `release_title`='$_POST[release_title]', `rating`='$_POST[rating]', `review`='$_POST[review]', `approved`='$_POST[approved]' WHERE ID = $_POST[id]";
        
                
    mysql_query($update) or die(mysql_error());

                
    header("Location: ../index.php");

        }
        
    ?>
    Any help would be greatly appreciated.

    Thanks

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    19,392
    The error means that mysql_query() returned FALSE, which means your query could not be parsed/processed by the database. You should inspect its result, and if false, log some debug info and display an error message (see mysql_error()).

    And now the public service announcements:

    The mysql_*() functions are deprecated, and you should instead be using either the mysqli extension or the PDO extension.

    Never put unsanitized user-supplied data directly into a query. (See mysql_real_escape_string() if you intend to continue using the mysql_*() functions, or prepared statements with bound input parameters with the more modern extensions.) http://xkcd.com/327/
    "Please give us a simple answer, so that we don't have to think, because if we think, we might find answers that don't fit the way we want the world to be."
    ~ Terry Pratchett in Nation

    eBookworm.us

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles