www.webdeveloper.com
Results 1 to 2 of 2

Thread: Trying to update database record but getting error

  1. #1
    Join Date
    Jul 2014
    Posts
    1

    Trying to update database record but getting error

    Hi

    So I'm new to php and followed some tutorials with updating records in a database. The tutorial I followed seems to work for them, but doesnt work for me and I get this error which I dont fully understand. Going to the edit page, the id in the url is correct, and it populates the input fields correctly, its just when i hit update i get the error.

    The error is as follows:
    Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in /home5/canaryde/public_html/m/reviews/edit_review.php on line 8

    PHP Code:
    <?php include '../includes/db_connect.php';
        
        
    $query " SELECT * FROM brads_reviews WHERE ID = $_GET[id] ";
        
    $result mysql_query($query);
        
    $show mysql_fetch_array($result);
        
    ?>
        
        <div class="container-fluid">
            <div class="row">
                
                <?php include '../includes/left_menu.php'?>

                <div class="col-lg-10 content-container">
                    <form role="form" action="<?php echo htmlentities($_SERVER['PHP_SELF']);?>" method="post">
                      <div class="form-group" style="display: none;">
                        <input type="text" class="form-control" value="<?php echo $show['review_date']; ?>" name="review_date" >
                      </div>
                      <div class="form-group">
                        <label for="artist_name">Artist Name</label>
                        <input type="text" class="form-control" name="artist_name" value="<?php echo $show['artist_name']; ?>">
                      </div>
                      <div class="form-group">
                        <label for="release_title">Release Title</label>
                        <input type="text" class="form-control" name="release_title" value="<?php echo $show['release_title']; ?>">
                      </div>
                      <div class="form-group">
                          <p>Currently rated: <?php echo $show['rating']; ?></p>
                          <br />
                        <label for="rating">Change Rating&nbsp;</label>
                        <select class="combobox" name="rating">
                            <option value="zero">0</option>
                            <option value="pointfive">0.5</option>
                            <option value="one">1</option>
                            <option value="onepointfive">1.5</option>
                            <option value="two">2</option>
                            <option value="twopointfive">2.5</option>
                            <option value="three">3</option>
                            <option value="threepointfive">3.5</option>
                            <option value="four">4</option>
                            <option value="fourpointfive">4.5</option>
                            <option value="five">5</option>
                        </select>
                      </div>
                      <div class="form-group">
                        <label for="review">Review</label>
                        <textarea type="text" class="form-control" name="review" id="editor_review" style="height: 10em;"><?php echo $show['review']; ?></textarea>
                      </div>
                      <div class="form-group">
                          <p>Currently Approved? <?php echo $show['approved']; ?></p>
                          <br />
                          <label for="review">Change Status&nbsp;</label>
                        <select class="combobox" name="approved">
                            <option value="Yes">Yes</option>
                            <option value="No">No</option>
                            <option value="Pending">Pending</option>
                        </select>
                      </div>
                      <input type="hidden" name="id" value="<?php echo $_GET['id']; ?>" />
                      <button type="submit" class="btn btn-primary">Update</button>
                    </form>
                </div>

            </div>

        </div>

        <?php include '../includes/javascript.php'?>
        
        <script>
            CKEDITOR.replace( 'editor_review' );
        </script>

        <?php 
        
    if(isset($_POST['submit'])) {
             
    $update "UPDATE brads_reviews SET `artist_name`='$_POST[artist_name]', `release_title`='$_POST[release_title]', `rating`='$_POST[rating]', `review`='$_POST[review]', `approved`='$_POST[approved]' WHERE ID = $_POST[id]";
        
                
    mysql_query($update) or die(mysql_error());

                
    header("Location: ../index.php");

        }
        
    ?>
    Any help would be greatly appreciated.

    Thanks

  2. #2
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,284
    The error means that mysql_query() returned FALSE, which means your query could not be parsed/processed by the database. You should inspect its result, and if false, log some debug info and display an error message (see mysql_error()).

    And now the public service announcements:

    The mysql_*() functions are deprecated, and you should instead be using either the mysqli extension or the PDO extension.

    Never put unsanitized user-supplied data directly into a query. (See mysql_real_escape_string() if you intend to continue using the mysql_*() functions, or prepared statements with bound input parameters with the more modern extensions.) http://xkcd.com/327/
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.26061 seconds
  • Memory Usage 2,878KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (2)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (2)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates