www.webdeveloper.com
Results 1 to 3 of 3

Thread: Slideshow

  1. #1
    Join Date
    Aug 2014
    Posts
    2

    Slideshow

    For starters I am completely new at Javascript, which makes this site extremely helpful, but I have run into a snag that I can not figure out. I found this script on the website

    /* This script and many more are available free online at
    The JavaScript Source :: http://www.javascriptsource.com
    Created by: Solomon, the Sleuth :: http://www.freewebs.com/thesleuth/scripts/ */

    var myImg= new Array(3)
    myImg[0]= "1";
    myImg[1]= "2";
    myImg[2]= "3";
    myImg[3]= "4";

    myImgSrc = "/images/";

    myImgEnd = ".jpg"

    var i = 0;

    function loadImg(){
    document.imgSrc.src = myImgSrc + myImg[i] + myImgEnd;
    }

    function prev(){
    if(i<1){
    var l = i
    } else {
    var l = i-=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    function next(){
    if(i>2){
    var l = i
    } else {
    var l = i+=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    window.onload=loadImg;


    It works great, but when I try to add more images to load, the page still does not go past the 4th image. This is what I have done to try to add more images:



    /* This script and many more are available free online at
    The JavaScript Source :: http://www.javascriptsource.com
    Created by: Solomon, the Sleuth :: http://www.freewebs.com/thesleuth/scripts/ */

    var myImg= new Array(7)
    myImg[0]= "1";
    myImg[1]= "2";
    myImg[2]= "3";
    myImg[3]= "4";
    myImg[4]= "5";
    myImg[5]= "6";
    myImg[6]= "7";
    myImg[7]= "8";

    myImgSrc = "/images/";

    myImgEnd = ".jpg"

    var i = 0;

    function loadImg(){
    document.imgSrc.src = myImgSrc + myImg[i] + myImgEnd;
    }

    function prev(){
    if(i<1){
    var l = i
    } else {
    var l = i-=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    function next(){
    if(i>2){
    var l = i
    } else {
    var l = i+=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    window.onload=loadImg;

    All images are in the /images folder, all .jpg extension and are named appropriately but when my site loads, it does not go past the 4th image.
    Like I said, new to javascript so layman terms would be appreciated

  2. #2
    Join Date
    Aug 2014
    Posts
    2
    You also have to change the if condition in the next() function to if(i>6) like so:
    Code:
    function next(){
    
    if(i>6){
    var l = i
    } else {
    var l = i+=1;
    } document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }
    That said, it's not maybe the best written script in the world.
    For example, I didn't even know that "var l = i+=1;" would evaluate "correctly", or at all for that matter.
    Maybe try out Cycle2 or bxslider.

    btw, next time, it would be helpful if you link the original source

  3. #3
    Join Date
    Aug 2014
    Posts
    2
    Thank you very much. After some research I realized this was clunky old code written in 2006. I ended up finding some code that works perfectly, and is a bit simpler.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.32969 seconds
  • Memory Usage 2,858KB
  • Queries Executed 15 (?)
More Information
Template Usage (33):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (1)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (3)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (3)postbit
  • (3)postbit_onlinestatus
  • (3)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates