www.webdeveloper.com
Results 1 to 4 of 4

Thread: Which is best for generating serial keys?

  1. #1
    Join Date
    Aug 2014
    Posts
    2

    Question Which is best for generating serial keys?

    Hi, so i've made a function called GenerateKey, and i've made 2 of them to see which solution was best, and i like the second one best.
    But how big is the difference on speed?
    Here's the first version:

    Code:
    function GenerateKey($name)
    {
    	$generated = strtoupper(md5($name).uniqid());
    	return rtrim(chunk_split(substr($generated, -24), 4, "-"), "-");
    }
    Then the second version(Which i like best):

    Code:
    function GenerateKey($length)
    {
    	$random = array('q','w','e','r','t','y','u','i','o','p','a','s','d','f','g','h','j','k','l','z','x','c','v','b','n','m','1','2','3','4','5','6','7','8','9');
    	$serial = "";
    
    	for ($i=0; $i < $length; $i++) { 
    		$randomChar = $random[mt_rand(0, 35)];
    
    		if(strlen($serial) < 20)
    		{
    			$serial .= $randomChar;
    		}
    	}
    	$key = chunk_split($serial, 4, "-");
    
    	return strtoupper(rtrim($key, "-"));
    }
    I know the $key variable is not needed, but i will change that later.

    So how's the speed, which is fastest, i bet the first one but i just like the second one best,
    and the result of the second one is so much better.

    :-)

  2. #2
    Join Date
    Aug 2014
    Posts
    2
    Can't seem to find the edit button, not sure if allowed to edit yet because i just registered.

    Anyway, i think the first solution is slower, i just ran a test, but i'm not sure if i'm calculating it correctly

    http://imgur.com/53mh7eR

    The bottom one is the first solution and the upper one is the second solution, so maybe the second solution is fastest?

  3. #3
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    I just felt like playing around with a different variation, to use/ignore at your discretion:
    PHP Code:
    <?php

    function getRandSerial($numChunks=4$separator='-')
    {
        
    $min 36*36*36;
        
    $max 36*36*36*36-1;
        
    $chunks = array();
        for(
    $i=0$i<$numChunks$i++)
        {
            
    $chunks[] = base_convert(rand($min$max), 1036);
        }
        return 
    implode($separator$chunks);
    }
    // test
    for($i=1$i<=10$i++)
    {
        echo 
    getRandSerial().PHP_EOL;
        echo 
    getRandSerial($i).PHP_EOL;
        echo 
    getRandSerial($i'.').PHP_EOL;
    }
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  4. #4
    Join Date
    May 2014
    Posts
    77
    I would remove any i I l L o O 1 0, these tend to give people too many headaches trying to figure out which is which.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.09433 seconds
  • Memory Usage 2,870KB
  • Queries Executed 13 (?)
More Information
Template Usage (34):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (2)bbcode_code
  • (1)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (4)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (71):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • tag_fetchbit
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates