Form entry with one or two fields entered

**florida** · 12-01-2004 03:41 PM

I have a form that works where someone puts in a last name AND first name to query an Access 2000 database. Now I want it to work where it takes either a last name or a first name and query the database. My form:

Code:

<form action="actionpage.jsp" method="post">
Last name:
<input type="Text" name="Name">
First Name
<input type="Text" name="F_Name">
<input type="Submit" value="Submit">
</form>

Action page:

Code:

<%@ page import="java.sql.*" %>
<% Class.forName("sun.jdbc.odbc.JdbcOdbcDriver"); %>


<body>
<% Connection connection = DriverManager.getConnection("jdbc:odbc:myDatabaseName", "", "");
Statement statement = connection.createStatement();
String name = request.getParameter("Name");
String name2 = request.getParameter("F_Name");

if((request.getParameter("Name") != null) && (request.getParameter("F_name") != null))
{
    ResultSet resultset = statement.executeQuery(
    "select * from poc where F_Name = '" + name2 + "' and Name = '" + name + "'"); 
}
else if((request.getParameter("Name") == null) && (request.getParameter("F_name") != null))
{
    ResultSet resultset = statement.executeQuery(
    "select * from poc where F_Name = '" + name2 + "'");
}
else if((request.getParameter("Name") != null) && (request.getParameter("F_name") == null))
{
    ResultSet resultset = statement.executeQuery(
    "select * from poc where Name = '" + name + "'");
}

<% while(resultset.next())
   { %>
   <%= resultset.getString(1) %>
   <%= resultset.getString(2) %>
  Results
   <% } %>

Please advise because it is not working.

**ray326** · 12-01-2004 04:01 PM

Please define "not working."

**florida** · 12-01-2004 07:26 PM

After I put in a first name or a last name or even both a first name and a last name it gives me error messages:

The below action page I used is called dbs8.jsp

Code:

Generated servlet error:
    [javac] Compiling 1 source file

C:\jakarta-tomcat-4.1.27\work\Standalone\localhost\examples\jsp\colors\dbs8_jsp.java:72: cannot resolve symbol
symbol  : variable resultset 
location: class org.apache.jsp.dbs8_jsp
 while(resultset.next())
       ^



An error occurred at line: 38 in the jsp file: /jsp/colors/dbs8.jsp

Generated servlet error:
C:\jakarta-tomcat-4.1.27\work\Standalone\localhost\examples\jsp\colors\dbs8_jsp.java:75: cannot resolve symbol
symbol  : variable resultset 
location: class org.apache.jsp.dbs8_jsp
      out.print( resultset.getString(1) );
                 ^

It seems to error on the resultset object. Please advise.

**buntine** · 12-01-2004 09:54 PM

Thats because your trying to access the variable out of scope. It only exists within the block in which it was created. (in this case, the if block)

Define the variable outside of trhe if statement and try again.

Regards.

**florida** · 12-02-2004 06:57 AM

Thanks! It works now.

Is it okay to repeat like this or is there a shorter way to do what I am doing?

Code:

if((request.getParameter("Name") != null) && (request.getParameter("F_name") != null))
{
    ResultSet resultset = statement.executeQuery(
    "select * from poc where F_Name = '" + name2 + "' and Name = '" + name + "'"); 
     while(resultset.next())
     {
         <%= resultset.getString(1) %>
         <%= resultset.getString(2) %>
     } 
}
else if((request.getParameter("Name") == null) && (request.getParameter("F_name") != null))
{
    ResultSet resultset = statement.executeQuery(
    "select * from poc where F_Name = '" + name2 + "'");
     while(resultset.next())
     {
         <%= resultset.getString(1) %>
         <%= resultset.getString(2) %>
     } 
}
else if((request.getParameter("Name") != null) && (request.getParameter("F_name") == null))
{
    ResultSet resultset = statement.executeQuery(
    "select * from poc where Name = '" + name + "'");
     while(resultset.next())
     {
         <%= resultset.getString(1) %>
         <%= resultset.getString(2) %>
     } 
}
%>

**ray326** · 12-02-2004 01:26 PM

Here it is (untested) refactored to eliminate the repetition.

Code:

boolean needAnd = false;
StringBuffer query = new StringBuffer("select * from poc where ");

if (request.getParameter("Name") != null)
{
    query.append("Name = '" + name + "'");
    needAnd = true;
}
if (request.getParameter("F_name") != null)
{
    if (needAnd) query.append(" and ");
    query.append("F_Name = '" + name2 + "'");
}

ResultSet resultset = statement.executeQuery(query.toString());
while(resultset.next())
{
 <%= resultset.getString(1) %>
 <%= resultset.getString(2) %>
}

**florida** · 12-02-2004 03:47 PM

Thank you.

Thread: Form entry with one or two fields entered

Thread Tools

Display

Form entry with one or two fields entered

Thread Information

Users Browsing this Thread

Bookmarks

Bookmarks

Posting Permissions