www.webdeveloper.com
Results 1 to 3 of 3

Thread: Slideshow

  1. #1
    Join Date
    Aug 2014
    Posts
    2

    Slideshow

    For starters I am completely new at Javascript, which makes this site extremely helpful, but I have run into a snag that I can not figure out. I found this script on the website

    /* This script and many more are available free online at
    The JavaScript Source :: http://www.javascriptsource.com
    Created by: Solomon, the Sleuth :: http://www.freewebs.com/thesleuth/scripts/ */

    var myImg= new Array(3)
    myImg[0]= "1";
    myImg[1]= "2";
    myImg[2]= "3";
    myImg[3]= "4";

    myImgSrc = "/images/";

    myImgEnd = ".jpg"

    var i = 0;

    function loadImg(){
    document.imgSrc.src = myImgSrc + myImg[i] + myImgEnd;
    }

    function prev(){
    if(i<1){
    var l = i
    } else {
    var l = i-=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    function next(){
    if(i>2){
    var l = i
    } else {
    var l = i+=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    window.onload=loadImg;


    It works great, but when I try to add more images to load, the page still does not go past the 4th image. This is what I have done to try to add more images:



    /* This script and many more are available free online at
    The JavaScript Source :: http://www.javascriptsource.com
    Created by: Solomon, the Sleuth :: http://www.freewebs.com/thesleuth/scripts/ */

    var myImg= new Array(7)
    myImg[0]= "1";
    myImg[1]= "2";
    myImg[2]= "3";
    myImg[3]= "4";
    myImg[4]= "5";
    myImg[5]= "6";
    myImg[6]= "7";
    myImg[7]= "8";

    myImgSrc = "/images/";

    myImgEnd = ".jpg"

    var i = 0;

    function loadImg(){
    document.imgSrc.src = myImgSrc + myImg[i] + myImgEnd;
    }

    function prev(){
    if(i<1){
    var l = i
    } else {
    var l = i-=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    function next(){
    if(i>2){
    var l = i
    } else {
    var l = i+=1;
    }
    document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }

    window.onload=loadImg;

    All images are in the /images folder, all .jpg extension and are named appropriately but when my site loads, it does not go past the 4th image.
    Like I said, new to javascript so layman terms would be appreciated

  2. #2
    Join Date
    Aug 2014
    Posts
    2
    You also have to change the if condition in the next() function to if(i>6) like so:
    Code:
    function next(){
    
    if(i>6){
    var l = i
    } else {
    var l = i+=1;
    } document.imgSrc.src = myImgSrc + myImg[l] + myImgEnd;
    }
    That said, it's not maybe the best written script in the world.
    For example, I didn't even know that "var l = i+=1;" would evaluate "correctly", or at all for that matter.
    Maybe try out Cycle2 or bxslider.

    btw, next time, it would be helpful if you link the original source

  3. #3
    Join Date
    Aug 2014
    Posts
    2
    Thank you very much. After some research I realized this was clunky old code written in 2006. I ended up finding some code that works perfectly, and is a bit simpler.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles