Nesting if commands

[conputerguy99]

I'm trying to make a script that will check for a username then if user=abc, for instance, check if pass=123. Here is my code.

<?php
$name = $_GET['name'];
$pass = $_GET['pass'];
if($name == "Joan Jones"){if($pass == "karen94"){print "Hello $name"}else{print "naughty naughty"}};
?>

[bokeh]

What's wrong with what you are using? What you are doing is a bit basic. What you need is to store all the usernames and passwords either in a file or database. In this example I will use an array to store username and password a design which can be easily extended manually.

<?php
// a make user array
$users = array('abc' => '123');

// check user exists or exit
if(!array_key_exists($_GET['name'], $users))exit('Naughty Naughty');

// check password corresponds with user or exit
if($users[$_GET['name']] != $_GET['pass'])exit('Naughty naughty');

print 'Hello '.$_GET['name'];
?>

[NogDog]

You can use a logical "and" in this case instead of nested ifs.

$name = $_GET['name'];
$pass = $_GET['pass'];
if($name == "Joan Jones" and $pass == "karen94")
{
  print "Hello $name";
}
else
{
  print "naughty naughty";
} 

[conputerguy99]

Thanks!