www.webdeveloper.com
Page 1 of 2 12 LastLast
Results 1 to 15 of 16

Thread: deleting a record from a database

  1. #1
    Join Date
    Jan 2006
    Posts
    64

    Question deleting a record from a database

    My database is coming on leaps and bounds. Now I'm trying to delete a record from it, but what seems to be happening is the record is being blanked, but not deleted. This is the script I have:

    PHP Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
    "http://www.w3.org/TR/html4/loose.dtd">
    <html>
    <head>
    <meta http-equiv="content-type" content="text/html;charset=iso-8859-1">
    <meta name="generator" content="Taco HTML Edit">
    <link rel="stylesheet" href="styles.css" type="text/css">
    <title>Amir&rsquo;s Contacts Database ~ Record Updated</title>
    </head>
    <body>
    <h1>Amir&rsquo;s Contacts Database</h1>
    <h2>Record Updated</h2>
    <?
    $id
    =$_POST['id'];

    $user="user";
    $password="password";
    $database="database";

    mysql_connect(localhost,$user,$password);
    @
    mysql_select_db($database) or die( "Unable to select database");

    $query="DELETE FROM contacts WHERE id='$id'";
    mysql_query($query);
    mysql_close();
    ?>
    <br>
    <a href="list.php">list</a>
    </body>
    </html>

  2. #2
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    you should do some error checking on your query if you don't think its working
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'" or die("Error:"mysql_error()); 
    mysql_query($query); 
    mysql_close(); 
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  3. #3
    Join Date
    Jan 2006
    Posts
    64
    I tried that, but nothing happened. Should I have got an error message if the query failed?

  4. #4
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    is the page not rendering? add an echo
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  5. #5
    Join Date
    Jan 2006
    Posts
    64
    The page is rendering fine, but the record is not deleted.

    I tried deleting it through SQL in PHPMyAdmin, and it worked fine. So I guess there must be something wrong with my script?

    What I'm doing is this:

    I have a list, on which there is a link to a 'delete' page. On this page, there's a link to the page doing the deleting. It looks like this:

    PHP Code:
    <input type="submit" onClick="parent.location='deleted.php'" value="delete" name="submitButtonName"

  6. #6
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    how are you passing the id?
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  7. #7
    Join Date
    Jan 2006
    Posts
    64
    Okay, it's gonna sound crazy, but I didn't realise I needed to, cos I didn't need it to update a record.

    It's passed to the 'delete' page like this:

    PHP Code:
    <? echo '<a href="delete.php?id='.$id.'">d</a>'?>

  8. #8
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    19,362
    Need to move the die() to the mysql_query() statement:
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " mysql_error());
    // it worked, so let's see what really happened:
    $numRows mysql_affected_rows();
    echo 
    "<p>$numRows rows were deleted from the database.</p>\n"
    "Please give us a simple answer, so that we don't have to think, because if we think, we might find answers that don't fit the way we want the world to be."
    ~ Terry Pratchett in Nation

    eBookworm.us

  9. #9
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    19,362
    Quote Originally Posted by Colm Osiris
    Okay, it's gonna sound crazy, but I didn't realise I needed to, cos I didn't need it to update a record.

    It's passed to the 'delete' page like this:

    PHP Code:
    <? echo '<a href="delete.php?id='.$id.'">d</a>'?>
    Try this:
    PHP Code:
     $query="DELETE FROM contacts WHERE id='{$_GET['id']}'"
    "Please give us a simple answer, so that we don't have to think, because if we think, we might find answers that don't fit the way we want the world to be."
    ~ Terry Pratchett in Nation

    eBookworm.us

  10. #10
    Join Date
    Jan 2006
    Posts
    64
    I'm afraid nothing changed. :-(

  11. #11
    Join Date
    Jan 2006
    Posts
    64
    Quote Originally Posted by NogDog
    Need to move the die() to the mysql_query() statement:
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " mysql_error());
    // it worked, so let's see what really happened:
    $numRows mysql_affected_rows();
    echo 
    "<p>$numRows rows were deleted from the database.</p>\n"
    I tried this, but saw no difference. The code I now have is:

    PHP Code:
    <?
    $id
    =$_POST['id'];

    $user="user";
    $password="password";
    $database="database";

    mysql_connect(localhost,$user,$password);
    @
    mysql_select_db($database) or die( "Unable to select database");

    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " mysql_error());
    // it worked, so let's see what really happened:
    $numRows mysql_affected_rows();
    echo 
    "<p>$numRows rows were deleted from the database.</p>\n"
    mysql_close();
    ?>

  12. #12
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    19,362
    Do the change of $id to {$_GET['id']} and I'll place a decent wager that it works.

    EDIT: I just noticed you're setting $id = $_POST['id'], so try changing that to $_GET['id'].
    "Please give us a simple answer, so that we don't have to think, because if we think, we might find answers that don't fit the way we want the world to be."
    ~ Terry Pratchett in Nation

    eBookworm.us

  13. #13
    Join Date
    Jan 2006
    Posts
    64
    what did the old, worn-out piece of string say to the brand new, unused piece of string?

    "I'm a frayed knot!"

  14. #14
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    Quote Originally Posted by NogDog
    Need to move the die() to the mysql_query() statement:
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " mysql_error());
    // it worked, so let's see what really happened:
    $numRows mysql_affected_rows();
    echo 
    "<p>$numRows rows were deleted from the database.</p>\n"
    That's what happens when I type with my eyes shut. Sorry about that.
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  15. #15
    Join Date
    Jan 2006
    Posts
    64
    What is? Sorry, I don't understand.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center



Recent Articles