www.webdeveloper.com
Page 1 of 2 12 LastLast
Results 1 to 15 of 16

Thread: deleting a record from a database

  1. #1
    Join Date
    Jan 2006
    Posts
    64

    Question deleting a record from a database

    My database is coming on leaps and bounds. Now I'm trying to delete a record from it, but what seems to be happening is the record is being blanked, but not deleted. This is the script I have:

    PHP Code:
    <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
    "http://www.w3.org/TR/html4/loose.dtd">
    <html>
    <head>
    <meta http-equiv="content-type" content="text/html;charset=iso-8859-1">
    <meta name="generator" content="Taco HTML Edit">
    <link rel="stylesheet" href="styles.css" type="text/css">
    <title>Amir&rsquo;s Contacts Database ~ Record Updated</title>
    </head>
    <body>
    <h1>Amir&rsquo;s Contacts Database</h1>
    <h2>Record Updated</h2>
    <?
    $id=$_POST['id'];

    $user="user";
    $password="password";
    $database="database";

    mysql_connect(localhost,$user,$password);
    @mysql_select_db($database) or die( "Unable to select database");

    $query="DELETE FROM contacts WHERE id='$id'";
    mysql_query($query);
    mysql_close();
    ?>
    <br>
    <a href="list.php">list</a>
    </body>
    </html>

  2. #2
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    you should do some error checking on your query if you don't think its working
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'" or die("Error:"mysql_error()); 
    mysql_query($query); 
    mysql_close(); 
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  3. #3
    Join Date
    Jan 2006
    Posts
    64
    I tried that, but nothing happened. Should I have got an error message if the query failed?

  4. #4
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    is the page not rendering? add an echo
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  5. #5
    Join Date
    Jan 2006
    Posts
    64
    The page is rendering fine, but the record is not deleted.

    I tried deleting it through SQL in PHPMyAdmin, and it worked fine. So I guess there must be something wrong with my script?

    What I'm doing is this:

    I have a list, on which there is a link to a 'delete' page. On this page, there's a link to the page doing the deleting. It looks like this:

    PHP Code:
    <input type="submit" onClick="parent.location='deleted.php'" value="delete" name="submitButtonName"

  6. #6
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    how are you passing the id?
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  7. #7
    Join Date
    Jan 2006
    Posts
    64
    Okay, it's gonna sound crazy, but I didn't realise I needed to, cos I didn't need it to update a record.

    It's passed to the 'delete' page like this:

    PHP Code:
    <? echo '<a href="delete.php?id='.$id.'">d</a>'?>

  8. #8
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    Need to move the die() to the mysql_query() statement:
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " mysql_error());
    // it worked, so let's see what really happened:
    $numRows mysql_affected_rows();
    echo 
    "<p>$numRows rows were deleted from the database.</p>\n"
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  9. #9
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    Quote Originally Posted by Colm Osiris
    Okay, it's gonna sound crazy, but I didn't realise I needed to, cos I didn't need it to update a record.

    It's passed to the 'delete' page like this:

    PHP Code:
    <? echo '<a href="delete.php?id='.$id.'">d</a>'?>
    Try this:
    PHP Code:
     $query="DELETE FROM contacts WHERE id='{$_GET['id']}'"
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  10. #10
    Join Date
    Jan 2006
    Posts
    64
    I'm afraid nothing changed. :-(

  11. #11
    Join Date
    Jan 2006
    Posts
    64
    Quote Originally Posted by NogDog
    Need to move the die() to the mysql_query() statement:
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " mysql_error());
    // it worked, so let's see what really happened:
    $numRows mysql_affected_rows();
    echo 
    "<p>$numRows rows were deleted from the database.</p>\n"
    I tried this, but saw no difference. The code I now have is:

    PHP Code:
    <?
    $id=$_POST['id'];

    $user="user";
    $password="password";
    $database="database";

    mysql_connect(localhost,$user,$password);
    @mysql_select_db($database) or die( "Unable to select database");

    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " . mysql_error());
    // it worked, so let's see what really happened:
    $numRows = mysql_affected_rows();
    echo "<p>$numRows rows were deleted from the database.</p>\n"; 
    mysql_close();
    ?>

  12. #12
    Join Date
    Aug 2004
    Location
    Ankh-Morpork
    Posts
    22,335
    Do the change of $id to {$_GET['id']} and I'll place a decent wager that it works.

    EDIT: I just noticed you're setting $id = $_POST['id'], so try changing that to $_GET['id'].
    "Well done....Consciousness to sarcasm in five seconds!" ~ Terry Pratchett, Night Watch

    How to Ask Questions the Smart Way (not affiliated with this site, but well worth reading)

    My Blog
    cwrBlog: simple, no-database PHP blogging framework

  13. #13
    Join Date
    Jan 2006
    Posts
    64
    what did the old, worn-out piece of string say to the brand new, unused piece of string?

    "I'm a frayed knot!"

  14. #14
    Join Date
    Aug 2005
    Location
    The Garden State
    Posts
    5,634
    Quote Originally Posted by NogDog
    Need to move the die() to the mysql_query() statement:
    PHP Code:
    $query="DELETE FROM contacts WHERE id='$id'";
    $result = @mysql_query($query)  or die("Query Failed; $query - " mysql_error());
    // it worked, so let's see what really happened:
    $numRows mysql_affected_rows();
    echo 
    "<p>$numRows rows were deleted from the database.</p>\n"
    That's what happens when I type with my eyes shut. Sorry about that.
    Acceptable Use | SQL Forum FAQ | celery is tasteless | twitter

    celery is tasteless - currently needing some UI time

  15. #15
    Join Date
    Jan 2006
    Posts
    64
    What is? Sorry, I don't understand.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
HTML5 Development Center

"

"

X vBulletin 4.2.2 Debug Information

  • Page Generation 0.16389 seconds
  • Memory Usage 3,027KB
  • Queries Executed 13 (?)
More Information
Template Usage (37):
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_global_above_footer
  • (1)ad_global_below_navbar
  • (1)ad_global_header1
  • (1)ad_global_header2
  • (1)ad_navbar_below
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)ad_thread_first_post_content
  • (1)ad_thread_last_post_content
  • (10)bbcode_php
  • (3)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)headinclude_bottom
  • (15)memberaction_dropdown
  • (1)navbar
  • (4)navbar_link
  • (1)navbar_moderation
  • (1)navbar_noticebit
  • (1)navbar_tabs
  • (2)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (15)postbit
  • (15)postbit_onlinestatus
  • (15)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available (6):
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files (26):
  • ./showthread.php
  • ./global.php
  • ./includes/class_bootstrap.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/functions_navigation.php
  • ./includes/class_friendly_url.php
  • ./includes/class_hook.php
  • ./includes/class_bootstrap_framework.php
  • ./vb/vb.php
  • ./vb/phrase.php
  • ./includes/functions_facebook.php
  • ./includes/functions_calendar.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_notice.php
  • ./packages/vbattach/attach.php
  • ./vb/types.php
  • ./vb/cache.php
  • ./vb/cache/db.php
  • ./vb/cache/observer/db.php
  • ./vb/cache/observer.php 

Hooks Called (72):
  • init_startup
  • friendlyurl_resolve_class
  • init_startup_session_setup_start
  • database_pre_fetch_array
  • database_post_fetch_array
  • init_startup_session_setup_complete
  • global_bootstrap_init_start
  • global_bootstrap_init_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • load_show_variables
  • load_forum_show_variables
  • global_state_check
  • global_bootstrap_complete
  • global_start
  • style_fetch
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • strip_bbcode
  • friendlyurl_clean_fragment
  • friendlyurl_geturl
  • forumjump
  • cache_templates
  • cache_templates_process
  • template_register_var
  • template_render_output
  • fetch_template_start
  • fetch_template_complete
  • parse_templates
  • fetch_musername
  • notices_check_start
  • notices_noticebit
  • process_templates_complete
  • friendlyurl_redirect_canonical
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • memberaction_dropdown
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • build_navigation_data
  • build_navigation_array
  • check_navigation_permission
  • process_navigation_links_start
  • process_navigation_links_complete
  • set_navigation_menu_element
  • build_navigation_menudata
  • build_navigation_listdata
  • build_navigation_list
  • set_navigation_tab_main
  • set_navigation_tab_fallback
  • navigation_tab_complete
  • fb_like_button
  • showthread_complete
  • page_templates