adding a bookmark using JS

[irf2k]

i have written the following code to generate a bookmark for the current page:

function errorMsg()
{
  alert("Your browser does not support this feature");
}
function addBookmark()
{
  var urlValue = "http://www.trackerurl.com?url="+escape(window.location); 
  var titleValue = window.name;
  if ((typeof window.sidebar == "object") && (typeof window.sidebar.addPanel == "function")) { 
	window.sidebar.addPanel(titleValue, urlValue,"");
  } else if ((typeof window.external == "object") && (typeof window.external.AddFavorite == "function")) { 
	window.external.AddFavorite(urlValue, titleValue); 
  } else {
    errorMsg();
  }
}

my problem has three parts:
1. The "titleValue = window.name;" does not seem to work correctly (what is the code to get the title of the current page?)
2. "(typeof window.external == "object") && (typeof window.external.AddFavorite == "function")" does not seem to work in IE which is what it is aimed at...if i use "if (window.external) it works fine...why?
3. Are there any other main browsers that I am not targeting with this code, and what should I do to add them?

thanks

[Fang]

1. document.title
2. & 3. http://labnol.blogspot.com/2006/01/a...k-firefox.html

[Kravvitz]

1) document.title is probably what you want.
2) I've wondered that myself.
3) Yes. Check out The Ultimate Add Bookmark Script.

[irf2k]

@kravvitz
The Ultimate Add Bookmark script seems little complex to me, since I'm not used to javascript...I like coding I can understand so I can play around with it if need be....
but regarding the site "http://labnol.blogspot.com/2006/01/add-to-favorites-ie-bookmark-firefox.html" posted by Fang....
how does this code work in Opera:
else if(window.opera && window.print) { // Opera Hotlist
return true; }

I mean, as far as I can see, it is just returning true, so its not really doing anything...I haven't tested it, but even if it worked, I'd like to know HOW...
thnx

[Fang]

Works in IE, FF and Opera:

<a href="#" rel="sidebar" onclick="if(document.all && !window.opera){ window.external.AddFavorite(location.href, document.title);return false; }else{ this.title = document.title; }" title="bookmark this page">Bookmark This Page</a>