Menu
Community /Pin to ProfileBookmark
@NogDogMar 21.2019 — #It's just one of several output options in that case. Anything not within
:)@NogDogMar 21.2019 — #@coleio#1602089
Best way to start to learn any PHP built-in function is via the official manual:https://php.net/sprintf :)@NogDogMar 22.2019 — #In this case it might be a bit of overkill to use
...versus...
I personally find the former easier to read and thus to maintain, but your mileage may vary.@NogDogMar 23.2019 — #@techb#1602137
Which, in my admittedly contrived example, might have some people doing:
You can make that more readable by doing some initial conversions to simple variables:
But now you're doing 3 additional variable assignments solely for the purpose of making your HTML output cleaner. Not a big deal, just adds a bit of code bloat.
Ultimately I'm not claiming any of these techniques (and other options) are correct/best, just that it's generally ugly when you combine HTML and PHP no matter which way you do it, and the main goal should be to use whichever technique in a given situation you think will be easiest to read/modify for you or whoever else has to modify it a year or two from now, when you've forgotten what you were doing and why. Don't just slap a bunch of HTML and PHP together in any old way that works and be satisfied. :)
PS: [u][HEREDOC notation](http://php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc) [/u] in PHP can help with the problems of having quotes in the output, which often makes embedding of JavaScript within the output easier.
curious about the way this code is written
Hi, im going through a tutorial on php from udemy.com and im curious about the following peice of code on it
[CODE]
<?php
global $connect;
$sql = “SELECT * FROM category”;
$stmt = $connect->query($sql);
while ($daterows = $stmt->fetch()){
$id = $daterows[“id”];
$categoryname = $daterows[“title”];
?>
<option><?php $categoryname; ?> </option>
<?php } ?>
why does the original author break up the while loop with php tags? i tried it the following way and it worked fine
[CODE]
<?php
global $connect;
$sql = “SELECT * FROM category”;
$stmt = $connect->query($sql);
while ($daterows = $stmt->fetch()){
$id = $daterows[“id”];
$categoryname = $daterows[“title”];
echo “<option> $categoryname </option>”;
}
?>
Sign in
to post a comment10 Comments(s) ↴
0
@NogDogMar 21.2019 — #It's just one of several output options in that case. Anything not within <?php...?>sprintf()<i>
</i><?php
// . . .
while($daterows = $stmt->fetch()) {
sprintf(
"<option>%s</option>n",
htmlspecialchars($daterows['title'])
);
}
:)
0
@NogDogMar 21.2019 — #Best way to start to learn any PHP built-in function is via the official manual:
0
@NogDogMar 22.2019 — #In this case it might be a bit of overkill to use printf()echoprintf()<i>
</i>printf(
"<p class='foo'>Hello, %s, your total cost for %s will be $%.2f.</p>n",
htmlspecialchars($user['first_name']),
htmlspecialchars($item['name']),
$item['price'] + (round($taxRate * $item['price'], 2)
);
...versus...
<i>
</i>echo "<p class='foo'>Hello, " . htmlspecialchars($user['first_name']) .
", your total cost for " . htmlspecialchars($item['name']) . " will be $" .
($item['price'] + (round($taxRate * $item['price'], 2))
;
I personally find the former easier to read and thus to maintain, but your mileage may vary.
0
@NogDogMar 23.2019 — #Which, in my admittedly contrived example, might have some people doing:
<i>
</i><p class='foo'>Hello, <?php echo htmlspecialchars($user['first_name']); ?>,
your total cost for <?php echo htmlspecialchars($item['name']); ?> will be $<?php
echo ($item['price'] + (round($taxRate * $item['price'], 2));?></p>
You can make that more readable by doing some initial conversions to simple variables:
<i>
</i><?php
$safe_first_name = htmlspecialchars($user['first_name']);
$safe_item_name = htmlspecialchars($item['name']);
$final_price = $item['price'] + (round($taxRate * $item['price'], 2);
?>
<p class='foo'>Hello, <?= $safe_first_name ?>, your total cost for <?= $safe_item_name ?>
will be $<?= $final_price ?>.</p>
<!-- OR -->
<?php echo "<p class='foo'>Hello, $safe_first_name, your total cost for $safe_item_name
will be $$final_price.</p>n";
But now you're doing 3 additional variable assignments solely for the purpose of making your HTML output cleaner. Not a big deal, just adds a bit of code bloat.
Ultimately I'm not claiming any of these techniques (and other options) are correct/best, just that it's generally ugly when you combine HTML and PHP no matter which way you do it, and the main goal should be to use whichever technique in a given situation you think will be easiest to read/modify for you or whoever else has to modify it a year or two from now, when you've forgotten what you were doing and why. Don't just slap a bunch of HTML and PHP together in any old way that works and be satisfied. :)
PS: [u]